Restore the build cache prior to running bin/pre_compile#321
Closed
edmorley wants to merge 1 commit into
Closed
Conversation
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this pull request
Aug 10, 2016
The Heroku pre_compile script is currently run prior to the cache being restored (heroku/heroku-buildpack-python#321), which means we have to tweak PATH so vendor-libmysqlclient.sh can find the binaries from the cache instead of the app directory. However the workaround added in #1770 only added one of the two extra required PATHs, this adds the other. Prior to this the buildpack compile would output: > ./bin/vendor-libmysqlclient.sh: line 65: pip: command not found ...and so wouldn't purge the old mysqlclient package, which is needed to force recompilation against the newer libmysqlclient. Once the PR against heroku-buildpack-python is merged, these workarounds can be removed.
Member
Author
|
Rebased against latest master. @kennethreitz any idea when you might be able to take a look at this? :-) |
Member
Author
|
Rebased against master. |
Contributor
|
rebase! |
Member
Author
|
Done :-) |
So that any changes made to `.heroku/` within pre_compile (such as installing additional libraries required for the later pip install) are not clobbered by the cache being copied over afterwards. Fixes #320.
Contributor
|
rebase :) |
Member
Author
|
Rebased again, please could you reopen? :-) |
Member
Author
|
Re-rebased after the re-landing of the bp-watch removal. @kennethreitz could you reopen? :-) |
Contributor
|
Strangely, GitHub won't let me re-open this PR. I'm very weary of making any changes to the caching logic, FWIW. |
Contributor
|
Can you open another PR? Sorry for the headache. |
Contributor
|
And for the untimeliness. |
Member
Author
Ah I think GitHub gets confused if the PR is rebased whilst being closed. I've reopened as #372. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that any changes made to
.heroku/within pre_compile (such as installing additional libraries required for the later pip install) are not clobbered by the cache being copied on top of it afterwards.Fixes #320.