This repository was archived by the owner on Feb 12, 2022. It is now read-only.
add "http://" to proxy if proxy not include protocol#235
Merged
geemus merged 1 commit intoheroku:masterfrom Feb 15, 2012
dekokun:proxy
Merged
add "http://" to proxy if proxy not include protocol#235geemus merged 1 commit intoheroku:masterfrom dekokun:proxy
geemus merged 1 commit intoheroku:masterfrom
dekokun:proxy
Conversation
Contributor
|
Thanks, I can see how it would be easy to leave that out (and it probably gave a not very helpful error too). Thanks! |
geemus
added a commit
that referenced
this pull request
Feb 15, 2012
add "http://" to proxy if proxy not include protocol
Contributor
Author
|
Thank you for merge ! |
Contributor
|
No problem, it was an easy mistake to make and an easy bug to fix. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you access with proxy, you can't use some API ex. 'heroku logs' 'heroku ps' in case of 'http_proxy=host:port'(without protocol)
I modified to add "http://" to proxy if proxy_env not include protocol.