Don't provision a Postgres database by default #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/stop-auto-provisioning-db
branch
2 times, most recently
from
80cca30 to
5c5457a
Compare
* The app no longer provisions a Postgres addon by default (since the Postgres adapter dependency in `requirements.txt` is commented out, which is what the Python buildpack uses to determine whether to auto-provision), so that it's possible to try the main part of the guide without incurring any additional charges beyond the eco dyno plan. * The Postgres DB addon has been removed from `app.json` too, which prevents it from being auto-provisioned for Review Apps too. * Help comments has been added to the `db` view function, to try and help prevent confusion due to errors on Heroku from the DB not being auto-provisioned. * The Postgres adapter has been switched from `psycopg2` to `psycopg`, which counter-intuitively is newer (`psycopg` is the v3 implementation of the adapter). The binary version of the package is now also used when not in production, to speed up local installation and reduce the chance of running into library/header issues. * The new Django DB connection health check feature has been enabled. * The unnecessary `HerokuDiscoverRunner` custom test runner and database`TEST` options have been removed. * An example `release` process entry has been added (commented out) to `Procfile`, which runs the Django DB migrations using the Heroku Release Phase feature. GUS-W-13152716.
edmorley
force-pushed
the
edmorley/stop-auto-provisioning-db
branch
from
5c5457a to
44dec2d
Compare
Member
Author
This was referenced Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txtis commented out, which is what the Python buildpack uses to determine whether to auto-provision), so that it's possible to try the main part of the guide without incurring any additional charges beyond the eco dyno plan.app.jsontoo, which prevents it from being auto-provisioned for Review Apps too.dbview function, to try and help prevent confusion due to errors on Heroku from the DB not being auto-provisioned.psycopg2topsycopg, which counter-intuitively is newer (psycopgis the v3 implementation of the adapter). The binary version of the package is now also used when not in production, to speed up local installation and reduce the chance of running into library/header issues.HerokuDiscoverRunnercustom test runner and databaseTESToptions have been removed.releaseprocess entry has been added (commented out) toProcfile, which runs the Django DB migrations using the Heroku Release Phase feature.The Python Getting Started guide on Heroku Dev Center will need to be updated at the same time as this is merged.
GUS-W-13152716.