Fix 'PromiseState.refresh should return a new PromiseState'#150
Merged
ryanbrainard merged 1 commit intomasterfrom Sep 23, 2016
Merged
Fix 'PromiseState.refresh should return a new PromiseState'#150ryanbrainard merged 1 commit intomasterfrom
ryanbrainard merged 1 commit intomasterfrom
Conversation
ryanbrainard
commented
Sep 22, 2016
| @@ -11,9 +11,17 @@ export default class PromiseState { | |||
| // creates as PromiseState that is refreshing | |||
| // can be called without a previous PromiseState and will be both pending and refreshing | |||
| static refresh(previous, meta) { | |||
Contributor
Author
There was a problem hiding this comment.
I didn't address it here, but was noticing how it's a little weird that meta here is only used if previous is undefined; although, it does act like resolve(value, meta) though. I believe I did that this to simplify some of the logic on the refetch size, but it makes this API a little ambiguous. Don't think it needs to be addressed now, but just calling it out for the future.
Contributor
There was a problem hiding this comment.
Yeah that's a little weird
Contributor
|
This looks great! 👍 |
Contributor
Author
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
cc: @nfcampos