Add Network Domains for IPv4 and IPv6 to Server#11
Merged
LKaemmerling merged 3 commits intomasterfrom Feb 14, 2019
Merged
Conversation
Add PublicNetwork Domain
LKaemmerling
force-pushed
the
add-network-domains
branch
from
1e91000 to
e7ece43
Compare
LD250
suggested changes
Feb 14, 2019
| assert bound_server.public_net.ipv6.network == "2001:db8::" | ||
| assert bound_server.public_net.ipv6.network_mask == "64" | ||
|
|
||
| bound_server.public_net.floating_ips = [478] |
Better Tests for BoundServer Init with PublicNetwork and BoundFloatingIP
LD250
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
This PR allows users to directly get the network and the network mask on the server ipv6 address and it documents/fix the result we give the user instead of returning the API result directly.