Skip to content

Conversation

@apricote
Copy link
Member

@apricote apricote commented Dec 9, 2025

I added the Experimental markers as described in https://hcloud-python.readthedocs.io/en/stable/#experimental-features

I saw that for DNS we only marked the methods. The docs specify that classes should also be marked, so I added it to the clients too.

@apricote apricote requested a review from jooola December 9, 2025 15:32
@apricote apricote self-assigned this Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (cfc6d97) to head (1325786).
⚠️ Report is 1 commits behind head on storage-boxes.

Additional details and impacted files
@@              Coverage Diff               @@
##           storage-boxes     #604   +/-   ##
==============================================
  Coverage          96.93%   96.93%           
==============================================
  Files                 74       74           
  Lines               3984     3984           
==============================================
  Hits                3862     3862           
  Misses               122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we didn't use a link to a GH issue in hcloud-go, so we do the same here?

@apricote
Copy link
Member Author

apricote commented Dec 9, 2025

I guess we didn't use a link to a GH issue in hcloud-go, so we do the same here?

That is what I figured, no strong opinion from my side.

@apricote apricote merged commit 0b8c73a into storage-boxes Dec 9, 2025
10 checks passed
@apricote apricote deleted the storage-boxes-experimental branch December 9, 2025 16:28
jooola pushed a commit that referenced this pull request Dec 9, 2025
…hods (#604)

I added the `Experimental` markers as described in
https://hcloud-python.readthedocs.io/en/stable/#experimental-features

I saw that for DNS we only marked the methods. The docs specify that
classes should also be marked, so I added it to the clients too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants