Add support for the networks parameter on server creation#78
Merged
LKaemmerling merged 4 commits intohetznercloud:masterfrom Feb 27, 2020
Merged
Conversation
LKaemmerling
requested changes
Feb 27, 2020
Member
LKaemmerling
left a comment
LKaemmerling
left a comment
There was a problem hiding this comment.
Thank you, this looks really good! I have a small suggestion for the documentation.
Co-Authored-By: Lukas Kämmerling <github@lukas-kaemmerling.de>
Member
LKaemmerling
left a comment
LKaemmerling
left a comment
There was a problem hiding this comment.
Could you add a line to the Changelog too?
LKaemmerling
requested changes
Feb 27, 2020
Contributor
Author
|
@LKaemmerling I just added a line to the changelog. I didn't bump the version thought. |
LKaemmerling
approved these changes
Feb 27, 2020
Member
|
I will merge it when the CI is ready. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API allows the specification of Network IDs which should be attached to the server private network interface at creation time. However, specifying networks when creating a server is not supported by this package yet.
This PR adds an optional
networksparameter to thehcloud.servers.client.ServersClient.createmethod and tests based on the ones for thevolumesparamether.Let me know, whether something needs to be adjusted. (Got late this night, better review my changes).