✨ feat: Add named capture in module patterns for back-referencing in allow/deny#17
Merged
✨ feat: Add named capture in module patterns for back-referencing in allow/deny#17
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Change return type from list[Rule] to list[tuple[Rule, dict[str, str]]], and update cli.py and tests to unpack tuples correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…he first Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{name}capture syntax inmodulespatterns that can be back-referenced inallow/denyrulesExample
When matching
contexts.boards.domain,{context}captures"boards", so onlycontexts.boards.domainis allowed — notcontexts.auth.domain.Changes
matcher.py: Addmatch_pattern_with_captures(), updatefind_matching_rules()to return captureschecker.py: Addresolve_captures(), updatecheck_import()with optionalcapturesparametercli.py: Thread captures from rule matching to import checkingREADME.md: Add Named Capture documentation section, update Hexagonal Architecture exampleCloses #16
Test plan
match_pattern_with_captures(single/multiple captures, duplicate name consistency, coexistence with*/**, backtracking)resolve_captures(single/multiple/no placeholders, unresolved placeholders)🤖 Generated with Claude Code