fix: resolve all codegen test failures and WASM build warnings#17
Merged
Conversation
- Fix hashmap contains_key codegen: emit i1 (bool) instead of i32, matching the MLIR op definition (fixes 5 native + 5 WASM tests) - Fix WASM runtime build: use *mut c_void in profiler stub to avoid referencing wasm-excluded cluster/connection/routing modules - Fix bridge.rs offset assertions: add wasm32 (32-bit pointer) values alongside existing 64-bit assertions - Remove dead WasmCell type from bridge.rs (replaced by OnceLock<Mutex>) - Eliminate all static_mut_refs warnings: replace static mut with Mutex in actor tracking (actor.rs) and WASM registry (registry.rs) - Gate vec byte-conversion helpers for native-only (fixes dead_code) - Add missing Debug derive on WasmReplyChannel All 438 codegen tests now pass (was 300/438). WASM runtime builds with zero warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contains_keycodegen: emiti1(bool) instead ofi32, matching the MLIR op definition — fixes 5 native + 5 WASM hashmap testscluster,connection,routing); bridge offset assertions hardcoded 64-bit values — fixes all 133 WASM test failuresstatic_mut_refswarnings: replacestatic mutwithMutexin actor tracking and WASM registry, remove deadWasmCelltype, gate native-only helpers, add missingDebugderiveTest plan
ctest— 438/438 codegen tests pass (was 300/438)cargo build -p hew-runtime --target wasm32-wasip1 --no-default-features— zero warningscargo test -p hew-runtime --all-features— 6 integration tests passcargo test -p hew-lexer -p hew-parser -p hew-types -p hew-lsp— all passcargo build -p hew-runtime— native build clean