deps: update jj-lib to 0.41#42
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the jj-lib and gix dependencies, necessitating a migration from synchronous iterators to asynchronous streams for repository operations such as walking predecessors and evaluating revsets. The ignore matching logic in working_copy_ignore.rs was also refactored to utilize RepoPath types instead of raw strings. Review feedback identified a regression in error handling within immutable_commit_ids where a single error now aborts the entire operation, and suggested an optimization to reduce string allocations during directory key reconstruction in the ignore matcher.
a7a6fc9 to
3dc725d
Compare
hewigovens
added a commit
that referenced
this pull request
May 7, 2026
- Rebased onto post-PR #42 main (jj-lib 0.41 + gix 0.83). Cargo.lock churn means this run is cold again; the new key populates the cache for future runs. - Drop the `tags: v*` trigger from appimage.yml. We're not shipping the AppImage as a release asset yet (no Linux icons/menus); workflow_dispatch only for now. - Tighten verbose comments in flake.nix to one-liners.
2 tasks
hewigovens
added a commit
that referenced
this pull request
May 8, 2026
…mments; drop tag trigger - Rebased onto post-#42 main (jj-lib 0.41 + gix 0.83). Cargo.lock churn means the cache key shifts; this run repopulates. - Bump actions/upload-artifact v4 -> v5 and cache-nix-action v6 -> v7. v6 was failing tar exit 2 on cache restore; v7 reworked the tarball strategy. Both ride Node 24 (v4/v6 were deprecated Node 20). - Drop the `tags: v*` trigger; we're not shipping the AppImage as a release asset yet (no Linux icons/menus). workflow_dispatch only. - Tighten verbose comments in flake.nix to one-liners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Rust core dependency set for
jj-lib0.41 andgix0.83 while keepingsha2aligned on 0.10.9.Details
Sendlocal streams.GitIgnoreFileAPI and preserves ignored-parent-directory behavior for watcher filtering.flake.nixwork in this PR.Validation
cargo check --workspacejust buildjust testjust lint