Fix: Enhance download logging and error handling

[hexawulf]

• Added detailed logging in FileUtils for file write operations, including absolute path, creation/deletion timestamps.
• Added detailed logging in KeyController for download attempts, including resolved path and resource status.
• Modified KeyController to return a JSON error response with 404 status if a file is not found during download, providing more context to the frontend.
• Verified path consistency between file writing and reading.
• Confirmed filename sanitization and URL encoding handling are robust.

Summary by CodeRabbit

• Bug Fixes

  • Improved error responses when requested files are not found or unreadable during download, now returning a detailed JSON error message instead of an empty response.

• Enhancements

  • Enhanced logging for file download attempts and temporary file lifecycle events, providing more detailed information for file creation, access, and deletion activities.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce enhanced logging and improved error response handling for file downloads and temporary file management. The KeyController's download method now provides detailed JSON error responses and logs, while FileUtils logs file creation, scheduled deletion, and deletion attempts with more context. One internal method signature in FileUtils was updated to accept additional logging information.

Changes

File(s)	Change Summary
src/main/java/com/keyjolt/controller/KeyController.java	Enhanced logging and error response in downloadFile; now returns JSON error details on file not found.
src/main/java/com/keyjolt/util/FileUtils.java	Improved logging for temp file creation and deletion; updated scheduleFileDeletion method signature.

Poem

In the warren of code, logs now shine bright,
File errors and temp files, all tracked in the light.
JSON replies for missing files, so clear,
And deletion logs whisper, "No need to fear!"
With every hop, our trace grows strong—
The rabbit devs cheer as the logs hop along! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a35ea0 and 67d2627.

📒 Files selected for processing (2)

• src/main/java/com/keyjolt/controller/KeyController.java (1 hunks)
• src/main/java/com/keyjolt/util/FileUtils.java (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.