Skip to content

fix stripe failing webhook #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BilalG1 merged 3 commits into from
Jan 13, 2026
Merged

fix stripe failing webhook #1102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f3eb7
fix stripe failing webhook
BilalG1 Jan 13, 2026
4471887
Merge branch 'dev' into fix-stripe-failing-webhook
BilalG1 Jan 13, 2026
b44a8c9
Merge branch 'dev' into fix-stripe-failing-webhook
BilalG1 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions apps/backend/src/lib/stripe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { getEnvVariable, getNodeEnvironment } from "@stackframe/stack-shared/dis
import { StackAssertionError, throwErr } from "@stackframe/stack-shared/dist/utils/errors";
import Stripe from "stripe";
import { createStripeProxy, type StripeOverridesMap } from "./stripe-proxy";
import { InputJsonValue } from "@prisma/client/runtime/client";
Comment thread
BilalG1 marked this conversation as resolved.

const stripeSecretKey = getEnvVariable("STACK_STRIPE_SECRET_KEY", "");
const useStripeMock = stripeSecretKey === "sk_test_mockstripekey" && ["development", "test"].includes(getNodeEnvironment());
Expand Down Expand Up @@ -92,6 +93,18 @@ export async function syncStripeSubscriptions(stripe: Stripe, stripeAccountId: s
}
const item = subscription.items.data[0];
const priceId = subscription.metadata.priceId as string | undefined;
// old subscriptions were created with offer metadata instead of product metadata
const productString = subscription.metadata.product as string | undefined ?? subscription.metadata.offer as string | undefined;
if (!productString) {
throw new StackAssertionError("Stripe subscription metadata missing product or offer", { subscriptionId: subscription.id });
}
let productJson: InputJsonValue;
try {
productJson = JSON.parse(productString);
} catch (error) {
throw new StackAssertionError("Invalid JSON in Stripe subscription metadata", { subscriptionId: subscription.id, productString, error });
}

await prisma.subscription.upsert({
where: {
tenancyId_stripeSubscriptionId: {
Expand All @@ -101,7 +114,7 @@ export async function syncStripeSubscriptions(stripe: Stripe, stripeAccountId: s
},
update: {
status: subscription.status,
product: JSON.parse(subscription.metadata.product),
product: productJson,
quantity: item.quantity ?? 1,
currentPeriodEnd: new Date(item.current_period_end * 1000),
currentPeriodStart: new Date(item.current_period_start * 1000),
Expand All @@ -112,9 +125,9 @@ export async function syncStripeSubscriptions(stripe: Stripe, stripeAccountId: s
tenancyId: tenancy.id,
customerId,
customerType,
productId: subscription.metadata.productId,
productId: subscription.metadata.productId as string | undefined ?? subscription.metadata.offerId,
priceId: priceId ?? null,
product: JSON.parse(subscription.metadata.product),
product: productJson,
Comment thread
BilalG1 marked this conversation as resolved.
quantity: item.quantity ?? 1,
stripeSubscriptionId: subscription.id,
status: subscription.status,
Expand Down