rename session recording to session replay #1207
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,22 @@ | ||
| ALTER TABLE "SessionRecordingChunk" RENAME COLUMN "tabId" TO "sessionReplaySegmentId"; | ||
|
|
||
| ALTER TABLE "SessionRecording" RENAME TO "SessionReplay"; | ||
| ALTER TABLE "SessionRecordingChunk" RENAME TO "SessionReplayChunk"; | ||
| ALTER TABLE "SessionReplayChunk" RENAME COLUMN "sessionRecordingId" TO "sessionReplayId"; | ||
|
|
||
| -- Rename primary key constraints | ||
| ALTER TABLE "SessionReplay" RENAME CONSTRAINT "SessionRecording_pkey" TO "SessionReplay_pkey"; | ||
| ALTER TABLE "SessionReplayChunk" RENAME CONSTRAINT "SessionRecordingChunk_pkey" TO "SessionReplayChunk_pkey"; | ||
|
|
||
| -- Rename foreign key constraints | ||
| ALTER TABLE "SessionReplay" RENAME CONSTRAINT "SessionRecording_tenancyId_fkey" TO "SessionReplay_tenancyId_fkey"; | ||
| ALTER TABLE "SessionReplay" RENAME CONSTRAINT "SessionRecording_tenancyId_projectUserId_fkey" TO "SessionReplay_tenancyId_projectUserId_fkey"; | ||
| ALTER TABLE "SessionReplayChunk" RENAME CONSTRAINT "SessionRecordingChunk_tenancyId_fkey" TO "SessionReplayChunk_tenancyId_fkey"; | ||
| ALTER TABLE "SessionReplayChunk" RENAME CONSTRAINT "SessionRecordingChunk_tenancyId_sessionRecordingId_fkey" TO "SessionReplayChunk_tenancyId_sessionReplayId_fkey"; | ||
|
|
||
| -- Rename indexes | ||
| ALTER INDEX "SessionRecording_tenancyId_lastEventAt_idx" RENAME TO "SessionReplay_tenancyId_lastEventAt_idx"; | ||
| ALTER INDEX "SessionRecording_tenancyId_projectUserId_startedAt_idx" RENAME TO "SessionReplay_tenancyId_projectUserId_startedAt_idx"; | ||
| ALTER INDEX "SessionRecording_tenancyId_refreshTokenId_updatedAt_idx" RENAME TO "SessionReplay_tenancyId_refreshTokenId_updatedAt_idx"; | ||
| ALTER INDEX "SessionRecordingChunk_tenancyId_sessionRecordingId_batchId_key" RENAME TO "SessionReplayChunk_tenancyId_sessionReplayId_batchId_key"; | ||
| ALTER INDEX "SessionRecordingChunk_tenancyId_sessionRecordingId_createdA_idx" RENAME TO "SessionReplayChunk_tenancyId_sessionReplayId_createdAt_idx"; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1118,11 +1118,11 @@ async function seedDummyProject(options: DummyProjectSeedOptions) { | |
| userEmailToId, | ||
| }); | ||
|
|
||
| await seedDummySessionReplays({ | ||
| prisma: dummyPrisma, | ||
| tenancyId: dummyTenancy.id, | ||
| userEmailToId, | ||
| targetSessionReplayCount: 75 | ||
| }); | ||
|
|
||
| console.log('Seeded dummy project data'); | ||
|
|
@@ -1773,43 +1773,43 @@ async function seedDummySessionActivityEvents(options: SessionActivityEventSeedO | |
| console.log('Finished seeding session activity events'); | ||
| } | ||
|
|
||
| type SessionReplaySeedOptions = { | ||
| prisma: PrismaClientTransaction, | ||
| tenancyId: string, | ||
| userEmailToId: Map<string, string>, | ||
| targetSessionReplayCount?: number, | ||
| }; | ||
|
|
||
| async function seedDummySessionReplays(options: SessionReplaySeedOptions) { | ||
| const { | ||
| prisma, | ||
| tenancyId, | ||
| userEmailToId, | ||
| targetSessionReplayCount = 250, | ||
| } = options; | ||
|
|
||
| const existingCount = await prisma.sessionReplay.count({ | ||
| where: { | ||
| tenancyId, | ||
| }, | ||
| }); | ||
|
|
||
| if (existingCount >= targetSessionReplayCount) { | ||
| console.log(`Dummy project already has ${existingCount} session replays, skipping seeding`); | ||
| return; | ||
| } | ||
|
|
||
| const toCreate = targetSessionReplayCount - existingCount; | ||
| const userIds = Array.from(userEmailToId.values()); | ||
| if (userIds.length === 0) { | ||
| throw new Error('Cannot seed session replays: no dummy project users exist'); | ||
| } | ||
|
|
||
| const now = new Date(); | ||
| const twoWeeksAgo = new Date(now); | ||
| twoWeeksAgo.setDate(twoWeeksAgo.getDate() - 14); | ||
|
|
||
| const seeds: Prisma.SessionReplayCreateManyInput[] = []; | ||
| for (let i = 0; i < toCreate; i++) { | ||
| const startedAt = new Date( | ||
| twoWeeksAgo.getTime() + Math.random() * (now.getTime() - twoWeeksAgo.getTime()), | ||
|
|
@@ -1828,9 +1828,9 @@ async function seedDummySessionRecordings(options: SessionRecordingSeedOptions) | |
| }); | ||
| } | ||
|
|
||
| await prisma.sessionReplay.createMany({ | ||
| data: seeds, | ||
| }); | ||
|
|
||
| console.log(`Seeded ${toCreate} session replays`); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ export const GET = createSmartRouteHandler({ | |
| tenancy: adaptSchema.defined(), | ||
| }).defined(), | ||
| params: yupObject({ | ||
| session_replay_id: yupString().defined(), | ||
| chunk_id: yupString().defined(), | ||
| }).defined(), | ||
| }), | ||
|
|
@@ -31,13 +31,13 @@ export const GET = createSmartRouteHandler({ | |
| async handler({ auth, params }) { | ||
| const prisma = await getPrismaClientForTenancy(auth.tenancy); | ||
|
|
||
| const sessionReplayId = params.session_replay_id; | ||
| const chunkId = params.chunk_id; | ||
|
|
||
| const chunk = await prisma.sessionReplayChunk.findFirst({ | ||
| where: { | ||
| tenancyId: auth.tenancy.id, | ||
| sessionReplayId, | ||
| id: chunkId, | ||
| }, | ||
| select: { | ||
|
|
@@ -64,20 +64,20 @@ export const GET = createSmartRouteHandler({ | |
| try { | ||
| parsed = JSON.parse(new TextDecoder().decode(unzipped)); | ||
| } catch (e) { | ||
| throw new StackAssertionError("Failed to decode session replay chunk JSON", { cause: e }); | ||
| } | ||
|
|
||
| if (typeof parsed !== "object" || parsed === null) { | ||
| throw new StackAssertionError("Decoded session replay chunk is not an object"); | ||
| } | ||
| if (parsed.session_replay_id !== sessionReplayId) { | ||
| throw new StackAssertionError("Decoded session replay chunk session_replay_id mismatch", { | ||
| expected: sessionReplayId, | ||
| actual: parsed.session_replay_id, | ||
| }); | ||
| } | ||
| if (!Array.isArray(parsed.events)) { | ||
| throw new StackAssertionError("Decoded session replay chunk events is not an array"); | ||
| } | ||
|
|
||
| return { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ export const GET = createSmartRouteHandler({ | |
| tenancy: adaptSchema.defined(), | ||
| }).defined(), | ||
| params: yupObject({ | ||
| session_replay_id: yupString().defined(), | ||
| }).defined(), | ||
| query: yupObject({ | ||
| cursor: yupString().optional(), | ||
|
|
@@ -45,13 +45,13 @@ export const GET = createSmartRouteHandler({ | |
| async handler({ auth, params, query }) { | ||
| const prisma = await getPrismaClientForTenancy(auth.tenancy); | ||
|
|
||
| const sessionReplayId = params.session_replay_id; | ||
| const exists = await prisma.sessionReplay.findUnique({ | ||
| where: { tenancyId_id: { tenancyId: auth.tenancy.id, id: sessionReplayId } }, | ||
| select: { id: true }, | ||
| }); | ||
| if (!exists) { | ||
| throw new KnownErrors.ItemNotFound(sessionReplayId); | ||
| } | ||
|
|
||
| const rawLimit = query.limit ?? String(DEFAULT_LIMIT); | ||
|
|
@@ -61,10 +61,10 @@ export const GET = createSmartRouteHandler({ | |
| const cursorId = query.cursor; | ||
| let cursorPivot: { firstEventAt: Date } | null = null; | ||
| if (cursorId) { | ||
| cursorPivot = await prisma.sessionReplayChunk.findFirst({ | ||
| where: { | ||
| tenancyId: auth.tenancy.id, | ||
| sessionReplayId, | ||
| id: cursorId, | ||
| }, | ||
| select: { firstEventAt: true }, | ||
|
|
@@ -74,17 +74,17 @@ export const GET = createSmartRouteHandler({ | |
| } | ||
| } | ||
|
|
||
| const cursorWhere: Prisma.SessionReplayChunkWhereInput = cursorId && cursorPivot ? { | ||
| OR: [ | ||
| { firstEventAt: { gt: cursorPivot.firstEventAt } }, | ||
| { AND: [{ firstEventAt: { equals: cursorPivot.firstEventAt } }, { id: { gt: cursorId } }] }, | ||
| ], | ||
| } : {}; | ||
|
|
||
| const chunks = await prisma.sessionReplayChunk.findMany({ | ||
| where: { | ||
| tenancyId: auth.tenancy.id, | ||
| sessionReplayId, | ||
| ...cursorWhere, | ||
| }, | ||
| orderBy: [{ firstEventAt: "asc" }, { id: "asc" }], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ export const GET = createSmartRouteHandler({ | |
| tenancy: adaptSchema.defined(), | ||
| }).defined(), | ||
| params: yupObject({ | ||
| session_replay_id: yupString().defined(), | ||
| }).defined(), | ||
| query: yupObject({ | ||
| offset: yupString().optional(), | ||
|
|
@@ -49,19 +49,19 @@ export const GET = createSmartRouteHandler({ | |
| async handler({ auth, params, query }) { | ||
| const prisma = await getPrismaClientForTenancy(auth.tenancy); | ||
|
|
||
| const sessionReplayId = params.session_replay_id; | ||
| const exists = await prisma.sessionReplay.findUnique({ | ||
| where: { tenancyId_id: { tenancyId: auth.tenancy.id, id: sessionReplayId } }, | ||
| select: { id: true }, | ||
| }); | ||
| if (!exists) { | ||
| throw new KnownErrors.ItemNotFound(sessionReplayId); | ||
| } | ||
|
|
||
| const chunks = await prisma.sessionReplayChunk.findMany({ | ||
| where: { | ||
| tenancyId: auth.tenancy.id, | ||
| sessionReplayId, | ||
| }, | ||
| orderBy: [{ firstEventAt: "asc" }, { id: "asc" }], | ||
| select: { | ||
|
|
@@ -110,20 +110,20 @@ export const GET = createSmartRouteHandler({ | |
| try { | ||
| parsed = JSON.parse(new TextDecoder().decode(unzipped)); | ||
| } catch (e) { | ||
| throw new StackAssertionError("Failed to decode session replay chunk JSON", { cause: e }); | ||
| } | ||
|
|
||
| if (typeof parsed !== "object" || parsed === null) { | ||
| throw new StackAssertionError("Decoded session replay chunk is not an object"); | ||
| } | ||
| if (parsed.session_replay_id !== sessionReplayId) { | ||
| throw new StackAssertionError("Decoded session replay chunk session_replay_id mismatch", { | ||
|
There was a problem hiding this comment. Session replay event retrieval throws error for old S3 data that uses  |
||
| expected: sessionReplayId, | ||
| actual: parsed.session_replay_id, | ||
| }); | ||
| } | ||
| if (!Array.isArray(parsed.events)) { | ||
| throw new StackAssertionError("Decoded session replay chunk events is not an array"); | ||
| } | ||
|
|
||
| chunkEvents[idx] = { chunk_id: chunk.id, events: parsed.events as any[] }; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying an already-committed migration
This migration file previously contained only one statement (renaming the
tabIdcolumn), which was already committed on the base branchrename-replay-tab-id. This PR appends three additional DDL statements to the same migration file.Prisma tracks which migrations have been applied by storing the SQL content hash in
_prisma_migrations. Any environment that already ran the original single-line migration will have a hash mismatch against this updated file. Whenprisma migrate deployis next run on such an environment, Prisma will report a "drift" error and refuse to apply, because the applied migration no longer matches the file on disk.Since the base branch is a pre-merge feature branch (not yet applied to
devor production), the risk here is scoped to developer local environments and CI runs on the base branch. However, if any developer or CI runner has already applied the one-line migration against a real database, they will need to manually resolve the drift (e.g.prisma migrate resolve --applied).The safer practice is to add a new, separate migration file for the table renames (e.g.
20260217000000_rename_session_recording_tables_to_session_replay.sql). This keeps each migration atomic, avoids hash conflicts on any already-migrated database, and also fixes the misleading migration name (which currently only references thetabIdrename, not the table renames).