Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request updates the OpenAPI specifications for the ChangesCLI Auth Timeout Default
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR regenerates the checked-in OpenAPI schema files to reflect a prior backend change that reduced the
Confidence Score: 5/5Safe to merge — the three OpenAPI files are generated artifacts whose only change is syncing a default value that already differs in the backend source. The diff is exactly three single-line changes, all identical, all in generated documentation files. The new value (120,000 ms) matches what the backend route has already been enforcing. No runtime behavior is being altered by this PR. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant CLI Route (POST /auth/cli)
participant DB (CliAuthAttempt)
Client->>CLI Route (POST /auth/cli): POST { expires_in_millis? }
Note over CLI Route (POST /auth/cli): default: 120,000 ms (2 min)<br/>max: 900,000 ms (15 min)
CLI Route (POST /auth/cli)->>DB (CliAuthAttempt): INSERT with expiresAt = now + expires_in_millis
DB (CliAuthAttempt)-->>CLI Route (POST /auth/cli): { pollingCode, loginCode, expiresAt }
CLI Route (POST /auth/cli)-->>Client: { polling_code, login_code, expires_at }
Reviews (1): Last reviewed commit: "Regenerate OpenAPI schemas to match expi..." | Re-trigger Greptile |
Summary
apps/backend/src/app/api/latest/auth/cli/route.tsxchangedexpires_in_millis.defaultfrom 7,200,000 (2hr) to 120,000 (2min), but the checked-in OpenAPI JSONs indocs-mintlify/openapi/were never regenerated.lint_and_buildto fail ondev(and on every PR branched offdev) because CI runs the codegen and then errors on the resulting uncommitted diff.Changes
admin.json,client.json,server.jsonviapnpm --filter=@stackframe/backend codegen-docs.Test plan
lint_and_buildpasses on this PR.Summary by CodeRabbit