Skip to content

Regenerate OpenAPI schemas#1425

Merged
BilalG1 merged 1 commit intodevfrom
fix/regenerate-openapi-schemas
May 8, 2026
Merged

Regenerate OpenAPI schemas#1425
BilalG1 merged 1 commit intodevfrom
fix/regenerate-openapi-schemas

Conversation

@BilalG1
Copy link
Copy Markdown
Collaborator

@BilalG1 BilalG1 commented May 8, 2026

Summary

  • The CLI auth-attempt schema in apps/backend/src/app/api/latest/auth/cli/route.tsx changed expires_in_millis.default from 7,200,000 (2hr) to 120,000 (2min), but the checked-in OpenAPI JSONs in docs-mintlify/openapi/ were never regenerated.
  • This causes lint_and_build to fail on dev (and on every PR branched off dev) because CI runs the codegen and then errors on the resulting uncommitted diff.

Changes

  • Regenerated admin.json, client.json, server.json via pnpm --filter=@stackframe/backend codegen-docs.

Test plan

  • CI's lint_and_build passes on this PR.

Summary by CodeRabbit

  • Documentation
    • Updated CLI authentication token default expiration time from 2 hours to 2 minutes across API specifications.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stack-auth-hosted-components Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-auth-mcp Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-backend Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-dashboard Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-demo Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-docs Building Building Preview, Comment May 8, 2026 11:42pm
stack-preview-backend Ready Ready Preview, Comment May 8, 2026 11:42pm
stack-preview-dashboard Ready Ready Preview, Comment May 8, 2026 11:42pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63f5f623-1514-432b-909b-65dec63e9aa6

📥 Commits

Reviewing files that changed from the base of the PR and between 3422deb and a60a598.

📒 Files selected for processing (3)
  • docs-mintlify/openapi/admin.json
  • docs-mintlify/openapi/client.json
  • docs-mintlify/openapi/server.json

📝 Walkthrough

Walkthrough

The pull request updates the OpenAPI specifications for the POST /auth/cli endpoint across three schema files (admin, client, and server). The expires_in_millis request-body field default value is reduced from 7200000 milliseconds (2 hours) to 120000 milliseconds (2 minutes).

Changes

CLI Auth Timeout Default

Layer / File(s) Summary
OpenAPI Schema Defaults
docs-mintlify/openapi/admin.json, docs-mintlify/openapi/client.json, docs-mintlify/openapi/server.json
CLI authentication token expires_in_millis default value reduced from 7200000 to 120000 across all three OpenAPI endpoint specifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops with freshened pace,
Two minutes now, the timeout's face!
From hours long to moments quick,
The auth CLI gets the trick. 🐰⏱️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Regenerate OpenAPI schemas' directly and clearly reflects the main change: regenerating three OpenAPI JSON files after a default value update.
Description check ✅ Passed The description fully covers the issue (outdated OpenAPI files), the solution (regenerating them), and includes a test plan, meeting repository requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/regenerate-openapi-schemas

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Greptile Summary

This PR regenerates the checked-in OpenAPI schema files to reflect a prior backend change that reduced the expires_in_millis default for CLI auth sessions from 7,200,000 ms (2 hours) to 120,000 ms (2 minutes). All three files (admin.json, client.json, server.json) receive the identical single-field update.

  • The sole change in each file is updating expires_in_millis.default from 7200000 to 120000 in the CLI auth-attempt request body schema, matching the value already live in apps/backend/src/app/api/latest/auth/cli/route.tsx (which also enforces a 15-minute maximum).
  • No logic, endpoint structure, or other schema fields are modified; this is a pure codegen sync to unblock CI.

Confidence Score: 5/5

Safe to merge — the three OpenAPI files are generated artifacts whose only change is syncing a default value that already differs in the backend source.

The diff is exactly three single-line changes, all identical, all in generated documentation files. The new value (120,000 ms) matches what the backend route has already been enforcing. No runtime behavior is being altered by this PR.

No files require special attention.

Important Files Changed

Filename Overview
docs-mintlify/openapi/admin.json Updates expires_in_millis default from 7200000 to 120000 in the CLI auth-attempt schema, matching the backend route change.
docs-mintlify/openapi/client.json Updates expires_in_millis default from 7200000 to 120000 in the CLI auth-attempt schema, in sync with the backend and admin.json.
docs-mintlify/openapi/server.json Updates expires_in_millis default from 7200000 to 120000 in the CLI auth-attempt schema, in sync with the backend and the other OpenAPI files.

Sequence Diagram

sequenceDiagram
    participant Client
    participant CLI Route (POST /auth/cli)
    participant DB (CliAuthAttempt)

    Client->>CLI Route (POST /auth/cli): POST { expires_in_millis? }
    Note over CLI Route (POST /auth/cli): default: 120,000 ms (2 min)<br/>max: 900,000 ms (15 min)
    CLI Route (POST /auth/cli)->>DB (CliAuthAttempt): INSERT with expiresAt = now + expires_in_millis
    DB (CliAuthAttempt)-->>CLI Route (POST /auth/cli): { pollingCode, loginCode, expiresAt }
    CLI Route (POST /auth/cli)-->>Client: { polling_code, login_code, expires_at }
Loading

Reviews (1): Last reviewed commit: "Regenerate OpenAPI schemas to match expi..." | Re-trigger Greptile

@BilalG1 BilalG1 merged commit fb81b41 into dev May 8, 2026
30 of 35 checks passed
@BilalG1 BilalG1 deleted the fix/regenerate-openapi-schemas branch May 8, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant