Skip to content

fix(dashboard): show Stack Auth logo on left of rebrand modal#1495

Merged
BilalG1 merged 1 commit into
devfrom
fix-stack-logo-in-modal
May 27, 2026
Merged

fix(dashboard): show Stack Auth logo on left of rebrand modal#1495
BilalG1 merged 1 commit into
devfrom
fix-stack-logo-in-modal

Conversation

@BilalG1
Copy link
Copy Markdown
Collaborator

@BilalG1 BilalG1 commented May 27, 2026

Summary

The Stack Auth → Hexclave rebrand modal added in #1493 rendered the Hexclave logo on both sides of its illustration instead of Stack Auth → Hexclave.

Root cause

`hexclave-rebrand-modal.tsx` referenced `/logo.svg` and `/logo-bright.svg` for the left-hand "Stack Auth" mark. But the visible-rebrand flip in #1481 replaced those files in `apps/dashboard/public/` with the Hexclave benzene mark — so post-merge, both `` slots resolved to the Hexclave logo.

Fix

  • Restored the pre-rebrand Stack Auth SVGs (lifted from `57ff5d3ce~1`, the commit before the brand-flip) under dedicated filenames so they can't get clobbered the next time `/logo.svg` is updated:
    • `apps/dashboard/public/stack-auth-logo.svg` — black mark, light theme
    • `apps/dashboard/public/stack-auth-logo-bright.svg` — white mark, dark theme
  • Pointed the modal's left-hand `` pair at the new paths and left a comment explaining why we don't share `/logo.svg` (so the next person doesn't try to consolidate it back).

The originals on `origin/dev` (`/logo.svg`, `/logo-bright.svg` = Hexclave) are untouched.

Verification

  • `pnpm --filter @stackframe/dashboard lint` — clean.
  • Diff of hexclave-rebrand-modal.tsx is two `src=` swaps plus a comment; the dismissal logic, gates, and storage key are untouched.

Summary by cubic

Fixes the rebrand modal to show the Stack Auth logo on the left instead of rendering Hexclave on both sides. Restores pre-rebrand assets as stack-auth-logo.svg and stack-auth-logo-bright.svg and updates the modal to use them for light/dark themes.

Written for commit f4ed262. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Style
    • Updated the rebrand modal illustration assets to display Stack Auth branding correctly.

Review Change Stack

The Stack Auth → Hexclave rebrand modal in #1493 referenced /logo.svg
and /logo-bright.svg expecting the Stack Auth mark, but the visible-
rebrand flip in #1481 replaced those public files with the Hexclave
benzene mark. The illustration ended up rendering Hexclave on both
sides instead of 'Stack Auth → Hexclave'.

Preserve the pre-rebrand Stack Auth SVGs under dedicated filenames
(stack-auth-logo{,-bright}.svg) so future brand-asset edits to
/logo.svg can't silently break the modal, and point the modal's
left-hand <Image> at them.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stack-auth-hosted-components Ready Ready Preview, Comment May 27, 2026 5:09pm
stack-auth-internal-tool Ready Ready Preview, Comment May 27, 2026 5:09pm
stack-auth-mcp Ready Ready Preview, Comment May 27, 2026 5:09pm
stack-auth-skills Ready Ready Preview, Comment May 27, 2026 5:09pm
stack-backend Building Building Preview, Comment May 27, 2026 5:09pm
stack-dashboard Ready Ready Preview, Comment May 27, 2026 5:09pm
stack-demo Building Building Preview, Comment May 27, 2026 5:09pm
stack-docs Building Building Preview, Comment May 27, 2026 5:09pm
stack-preview-backend Building Building Preview, Comment May 27, 2026 5:09pm
stack-preview-dashboard Ready Ready Preview, Comment May 27, 2026 5:09pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4881a542-1bb8-431c-8abb-7b738169a686

📥 Commits

Reviewing files that changed from the base of the PR and between 4f621f5 and f4ed262.

⛔ Files ignored due to path filters (2)
  • apps/dashboard/public/stack-auth-logo-bright.svg is excluded by !**/*.svg
  • apps/dashboard/public/stack-auth-logo.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • apps/dashboard/src/components/hexclave-rebrand-modal.tsx

📝 Walkthrough

Walkthrough

The rebrand modal illustration component is updated to reference dedicated Stack Auth logo assets instead of generic logo filenames, ensuring the correct visual presentation of the pre-rebrand branding during the modal flow.

Changes

Rebrand Modal Illustration

Layer / File(s) Summary
Stack Auth logo asset filename update
apps/dashboard/src/components/hexclave-rebrand-modal.tsx
RebrandIllustration swaps the Stack Auth logo image sources from generic /logo.svg and /logo-bright.svg to dedicated /stack-auth-logo.svg and /stack-auth-logo-bright.svg, with an updated comment explaining why those dedicated assets are preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • N2D4

Poem

🐰 A logo path adjusted with care,
Stack Auth branding shines bright and fair,
Assets preserved, the modal knows its way,
From generic names to dedicated display! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the rebrand modal to display the Stack Auth logo on the left side instead of Hexclave.
Description check ✅ Passed The description is comprehensive and well-structured, providing summary, root cause analysis, implementation details, and verification steps that thoroughly explain the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-stack-logo-in-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR fixes the rebrand modal illustration, which was showing the Hexclave logo on both sides after PR #1481 replaced /logo.svg with the Hexclave benzene mark. The fix adds dedicated stack-auth-logo.svg and stack-auth-logo-bright.svg files and updates the two src= references in RebrandIllustration to use them.

  • Two new SVG files added under unique filenames so they can't be silently overwritten by future brand-asset updates to /logo.svg.
  • The modal component change is minimal — only the two src= values and an explanatory comment are touched; dismissal logic, gates, and storage key are unchanged.

Confidence Score: 5/5

Safe to merge — the change is two path swaps in a purely decorative modal illustration with no logic, auth, or data-flow impact.

The diff is surgical: two new static SVG assets and two src= string replacements in a decorative component. The dismissal logic, user gate, localStorage handling, and environment checks are completely untouched. The new filenames are isolated from the canonical /logo.svg brand asset, so future brand flips won't regress this again.

No files require special attention.

Important Files Changed

Filename Overview
apps/dashboard/src/components/hexclave-rebrand-modal.tsx Two src= swaps in RebrandIllustration to point at the new dedicated Stack Auth SVG filenames; dismissal logic, gates, and storage key are untouched.
apps/dashboard/public/stack-auth-logo.svg New file: pre-rebrand Stack Auth mark (black fill) for light theme, added under a dedicated filename to avoid collisions with /logo.svg.
apps/dashboard/public/stack-auth-logo-bright.svg New file: pre-rebrand Stack Auth mark (white fill) for dark theme, mirroring the light-theme SVG with white fill for dark-mode rendering.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[RebrandIllustration renders] --> B{Theme}
    B -- light --> C["Image src='/stack-auth-logo.svg' block dark:hidden"]
    B -- dark --> D["Image src='/stack-auth-logo-bright.svg' hidden dark:block"]
    C --> E[Arrow SVG]
    D --> E
    E --> F["Image src='/hexclave-icon.svg'"]
    F --> G[Modal illustration complete]
Loading

Reviews (1): Last reviewed commit: "fix(dashboard): show Stack Auth logo on ..." | Re-trigger Greptile

@BilalG1 BilalG1 merged commit c753ab2 into dev May 27, 2026
32 of 37 checks passed
@BilalG1 BilalG1 deleted the fix-stack-logo-in-modal branch May 27, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant