Remove stack emulator CLI commands#1522
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughRemoves the ChangesEmulator command removal and terminology standardization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR removes the
Confidence Score: 4/5Safe to merge — the removal is complete and consistent across commands, build scripts, and docs, with no broken imports or missing call-site updates. The deletion of emulator.ts and its test file is clean, all registration and import sites are updated, and the messaging changes across exec/init/project/auth/local-emulator-client are consistent. The only residual issue is a handful of exported-but-now-unreferenced functions and constants left in emulator-paths.ts — dead code that doesn't affect runtime behaviour but should be cleaned up. packages/stack-cli/src/lib/emulator-paths.ts — several exported functions and constants are now unreachable and can be removed. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[stack CLI entry point\nindex.ts] --> B[registerExecCommand]
A --> C[registerInitCommand]
A --> D[registerProjectCommand]
A --> E[registerDevCommand]
A --> F[registerWhoamiCommand]
A --> G[registerFixCommand]
A --> H[registerDoctorCommand]
subgraph REMOVED ["❌ Removed"]
R1[registerEmulatorCommand\nemulator.ts]
R2[copyEmulatorAssets\ncopy-runtime-assets.mjs]
R3[emulator.test.ts]
end
C -->|"Local config file\n(was: Local emulator)"| C1[handleCreate\ncreates hexclave.config.ts only]
C -->|"Hexclave Cloud"| C2[handleCreateCloud\nwriteProjectKeysToEnv]
D --> D1["project list / create\n(--dev: development environment)"]
B --> B1["exec --config-file\n(was: local emulator)"]
B1 --> EP[emulator-paths.ts\nstill resolves PCK path + ports]
C1 --> EP
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs-mintlify/guides/going-further/cli.mdx (1)
75-75:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winStale emulator reference left in init description.
The init flow no longer offers an emulator-based option (it now offers "Hexclave Cloud" vs "Local config file"), but this line still tells users the wizard can "create a local config file for the emulator." Update to match the narrowed scope.
📝 Suggested wording
-The wizard can create a cloud project, create a local config file for the emulator, or link an existing project. In interactive terminals, it can run an agent to apply the setup changes to your app. Use `--no-agent` to print manual setup instructions instead. +The wizard can create a cloud project, create a local config file, or link an existing project. In interactive terminals, it can run an agent to apply the setup changes to your app. Use `--no-agent` to print manual setup instructions instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs-mintlify/guides/going-further/cli.mdx` at line 75, Summary: The init description incorrectly mentions creating "a local config file for the emulator" when the flow no longer supports an emulator; update the wording to reflect the actual options ("Hexclave Cloud" vs "Local config file"). Fix: edit the sentence in the init flow text (the line that currently reads "The wizard can create a cloud project, create a local config file for the emulator, or link an existing project...") to remove "for the emulator" and instead say something like "create a local config file" or explicitly "create a local config file for local use" and keep the rest of the sentence (including the note about running an agent and --no-agent) intact so it matches the current init options.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/stack-cli/src/commands/init.ts`:
- Around line 168-171: Replace the truthiness check on args.projectId with an
explicit null/undefined check: change the condition in init.ts from if
(args.projectId) to if (args.projectId != null) (or !== undefined if you
prefer), keeping the body that logs the dashboard URL and using
encodeURIComponent(args.projectId) as before; this ensures you're explicitly
testing for null/undefined rather than truthiness.
---
Outside diff comments:
In `@docs-mintlify/guides/going-further/cli.mdx`:
- Line 75: Summary: The init description incorrectly mentions creating "a local
config file for the emulator" when the flow no longer supports an emulator;
update the wording to reflect the actual options ("Hexclave Cloud" vs "Local
config file"). Fix: edit the sentence in the init flow text (the line that
currently reads "The wizard can create a cloud project, create a local config
file for the emulator, or link an existing project...") to remove "for the
emulator" and instead say something like "create a local config file" or
explicitly "create a local config file for local use" and keep the rest of the
sentence (including the note about running an agent and --no-agent) intact so it
matches the current init options.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b5f63f3-4b7b-4527-874d-c0a592324714
📒 Files selected for processing (11)
docs-mintlify/guides/going-further/cli.mdxpackages/stack-cli/scripts/copy-runtime-assets.mjspackages/stack-cli/src/commands/emulator.test.tspackages/stack-cli/src/commands/emulator.tspackages/stack-cli/src/commands/exec.tspackages/stack-cli/src/commands/init.tspackages/stack-cli/src/commands/project.tspackages/stack-cli/src/index.tspackages/stack-cli/src/lib/auth.tspackages/stack-cli/src/lib/emulator-paths.tspackages/stack-cli/src/lib/local-emulator-client.ts
💤 Files with no reviewable changes (3)
- packages/stack-cli/src/index.ts
- packages/stack-cli/src/commands/emulator.ts
- packages/stack-cli/src/commands/emulator.test.ts
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack emulatorcommand group.stack emulator start.Validation
pnpm --filter @stackframe/stack-cli typecheckcd packages/stack-cli && pnpm exec eslint --ext .tsx,.ts .pnpm -C /home/ubuntu/repos/stack-auth exec vitest run packages/stack-cli/srcpnpm -C /home/ubuntu/repos/stack-auth --filter @stackframe/stack-cli buildnode packages/stack-cli/dist/index.js --helppnpm -C /home/ubuntu/repos/stack-auth lintpnpm -C /home/ubuntu/repos/stack-auth codegenNote:
pnpm -C /home/ubuntu/repos/stack-auth typecheckcurrently fails in@stackframe/backendbecause generated Prisma client types are missing; the package-specific stack CLI typecheck passes.Link to Devin session: https://app.devin.ai/sessions/86ff0cfc6c30453ca6c2e05877d40499
Requested by: @N2D4
Summary by CodeRabbit
Documentation
Refactor
Chores