Fix CJS for stack-shared#676
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified package.json configuration in @stackframe/stack-shared to improve dual module system compatibility, focusing on CommonJS support while maintaining ESM functionality.
- Removed
main,types, andtype: modulefields from package.json for better CJS compatibility - Added
requireconditions inexportsfield to support proper CommonJS module resolution - Maintained ESM support through
defaultexport conditions in package.json - Ensured proper type definitions access through
typesfield in exports mapping
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+22
to
+23
| "default": "./dist/index.js" | ||
| }, |
Contributor
There was a problem hiding this comment.
style: Consider using './dist/cjs/index.js' instead of './dist/index.js' to explicitly separate CJS and ESM outputs
N2D4
added a commit
to willothy/stack
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fix CJS exports in
package.jsonofstack-sharedby addingrequirefields for compatibility.requirefields inexportsfor CJS compatibility inpackage.json."require": { "default": "./dist/index.js" }for main entry."require": { "default": "./dist/*.js" }for sub-paths.This description was created by
for 17607b3. You can customize this summary. It will automatically update as commits are pushed.