Skip to content

Remove semicolon from golang solution generator template #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Remove semicolon from golang solution generator template #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/app/apps/codebattle/test/docker_execution/golang_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ defmodule Codebattle.DockerExecution.GolangTest do
Mix.Shell.Process.flush()

Phoenix.ChannelTest.push(socket1, "check_result", %{
editor_text: "package main;\n\nfunc solution(a int64, b int64) int64 {\n\treturn a - b\n}",
editor_text: "package main\n\nfunc solution(a int64, b int64) int64 {\n\treturn a - b\n}",
lang_slug: "golang"
})

Expand Down Expand Up @@ -89,7 +89,7 @@ defmodule Codebattle.DockerExecution.GolangTest do
Phoenix.ChannelTest.push(socket1, "editor:data", %{editor_text: "test", lang_slug: "js"})

Phoenix.ChannelTest.push(socket1, "check_result", %{
editor_text: "package main;\n\nfunc solution(a int64, b int64) int64 {\n\treturn a + b\n}",
editor_text: "package main\n\nfunc solution(a int64, b int64) int64 {\n\treturn a + b\n}",
lang_slug: "golang"
})

Expand Down
2 changes: 1 addition & 1 deletion services/app/apps/runner/lib/runner/languages.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ defmodule Runner.Languages do
checker_file_name: "checker.go",
docker_image: "codebattle/golang:1.22.1",
solution_template: """
package main;
package main
// import "fmt"

func solution(<%= arguments %>)<%= expected %> {
Expand Down
2 changes: 1 addition & 1 deletion services/app/apps/runner/test/runner/solution_generator_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ defmodule Runner.SolutionGeneratorTest do
"""

@golang_expected """
package main;
package main
// import "fmt"

func solution(a int64, text string, b float64, c bool, nested_hash_of_string map[string]string, nested_array_of_string []string, nested_array_of_array_of_strings [][]string) []string {
Expand Down