Fix bug #2083 Filtering by tags doesn't work #2099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtm9
requested changes
Feb 25, 2025
| def get_task_by_tags_for_user(user, tags) do | ||
| @spec get_task_by_tags_for_user(User.t(), list(String.t()), String.t()) :: t() | nil | ||
| def get_task_by_tags_for_user(user, tags, level) do | ||
| __MODULE__ |
Contributor
There was a problem hiding this comment.
Set the default level to nil, meaning a task with a random level will be selected if no level is specified.
vtm9
approved these changes
Feb 27, 2025
Contributor
|
Will be merged in two days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
На стороне бэка не учитывался уровень задачи, когда мы активировали фильтр по тегам. Из-за этого пул задач состоял из всех уровней.
Task
Fixes #2083 Filtering tasks by tags does not work
Changes
Добавил учет уровня в функцию get_task_by_tags_for_user