Skip to content

Mocha version upgrade 2.5.3 to 4.0.1#2849

Merged
NoahDragon merged 4 commits intohexojs:masterfrom
segayuu:mocha-upgrade
Nov 16, 2017
Merged

Mocha version upgrade 2.5.3 to 4.0.1#2849
NoahDragon merged 4 commits intohexojs:masterfrom
segayuu:mocha-upgrade

Conversation

@segayuu
Copy link
Copy Markdown
Contributor

@segayuu segayuu commented Nov 16, 2017

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

Upgrade v3 or hither Error.
See https://mochajs.org/#working-with-promises
Error Message:
Resolution method is overspecified. Specify a callback *or* return a Promise; not both.
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 97.224% when pulling 8f8a431 on segayuu:mocha-upgrade into 5aa8b51 on hexojs:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 97.224% when pulling 6a2babe on segayuu:mocha-upgrade into 5aa8b51 on hexojs:master.

requireSemicolons: Missing semicolon after statement.
See https://travis-ci.org/hexojs/hexo/jobs/302843515
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 97.224% when pulling 16b476a on segayuu:mocha-upgrade into 5aa8b51 on hexojs:master.

Copy link
Copy Markdown
Collaborator

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLHwung JLHwung mentioned this pull request Nov 16, 2017
2 tasks
@NoahDragon NoahDragon merged commit b4dcdc8 into hexojs:master Nov 16, 2017
@segayuu segayuu deleted the mocha-upgrade branch November 16, 2017 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants