Conversation
…eateMemo, createEffect, memo, memoFn, composable); bump to 1.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes six public APIs that were either one-line forwards to existing primitives or identity wrappers, contradicting the SibuJS philosophy of plain verbs and no framework ceremony:
createSignal→ wasreturn signal(value). Usesignal()directly.createMemo→ wasreturn derived(fn). Usederived()directly.createEffect→ wasreturn effect(fn). Useeffect()directly.memo→ wasreturn derived(factory). Usederived()directly.memoFn→ wasreturn derived(callback). Usederived()directly.composable→ wasreturn setup(identity function). Plain functions are already composables in SibuJS.Three source files (
src/patterns/primitives.ts,src/core/signals/memo.ts,src/core/signals/memoFn.ts) are reduced to empty stubs and can be deleted from disk in a follow-up commit. All barrel exports, build helpers (ide.ts metadata + type stubs + snippets, linting hook list, analyzer module table, Vite/Webpack pure-annotation list, plugins/ecosystem metadata), internal JSDoc references, and the test suite have been updated accordingly. Version bumped to 1.4.0.Related Issue
Closes #
Type of Change
Checklist
npm run lint395 files clean,vitest run198 files / 2105 tests passing)