Fix registry ets package timestamp purging#1125
Open
elfenlaid wants to merge 1 commit intohexpm:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes fix typo in
timestampand nowHex.Registry.Server.prefetchshould properly clean all entries associated with packages fromstate.ets.The rest of the file uses
timestampkeys, like here:hex/lib/hex/registry/server.ex
Line 368 in 8886724
I also checked for typos in other keys or key that could be omitted from
purge_repo_matchspec, just in case, but everything seems fine aside from that typo intimestamp.