Add download stats and release dates to mix hex.info#1130
Merged
Conversation
This adds download counts and release dates (provided by `hex.pm/api/packages/[package_name]`) to the `mix hex.info [package_name]` and `mix hex.info [package_name] [version]` commands. Download counts for the overall package info include yesterday, last 7 days, and all-time. Showing the download numbers for the current version (like the Hex.pm website does) would require a second HTTP request, which seemed iffy. I also wasn't clear on what the "recent" key in the downloads meant (it looks like it might be the last 8 releases), so I left that out of the download output. Resolves hexpm#1128
Member
|
This is a great improvement! What do you think about something like this to format it nicer: |
43b1ee7 to
4479112
Compare
Contributor
Author
|
@ericmj, done! In 4479112, I've:
One thing I'm having trouble with is stubbing out the downloads in test. Ideally I'd do so in |
Member
|
You can use bypass to mock a hexpm response, there are existing examples of that in the tests. |
Contributor
Author
|
Ah, wonderful! Added a couple tests in 67f6180 👍 |
Restore iodata pipeline in format_releases so :yellow/:reset atoms reach Hex.Shell rather than being stringified by Enum.join. Fix "configs": atom-key in the release downloads test fixture that made release["configs"]["mix.exs"] return nil.
Drop the extra trailing "\n" in the Recent releases info call — each entry already ends with a newline and IO.puts adds another, which produced two blank lines. Add a leading newline so there's a blank line between the Config/Locked version block and the release list.
Member
|
This is great, thank you! 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds download counts and release dates (provided by
hex.pm/api/packages/[package_name]) to themix hex.info [package_name]andmix hex.info [package_name] [version]commands.Download counts for the overall package info include yesterday, last 7 days, and all-time.
Two decisions I'm not entirely sure of, but happy to revisit:
(The formatting on the before/after table below is a little weird... GitHub seems to be adding additional spaces between "paragraphs.")
Resolves #1128