Gate API key to OAuth token exchange on oauth_exchange == true#1148
Merged
Conversation
The second-priority branch in build_hex_core_config attempted to exchange the API key for an OAuth token whenever auth_key and trusted were set, relying on the first branch to short-circuit for the disabled case. That left the branch's condition incomplete: any state not caught by branch 1 would fire exchange, even states that should not (e.g. organization repos propagated from a parent without oauth_exchange set, which resolve to an explicit nil). Make both branches self-gated on the oauth_exchange flag so the intent is local to each clause. Also clarify preflight comments in remote_converger.
ericmj
force-pushed
the
ericmj/fix-oauth-exchange-gating
branch
from
9600449 to
6410ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second-priority branch in build_hex_core_config attempted to exchange
the API key for an OAuth token whenever auth_key and trusted were set,
relying on the first branch to short-circuit for the disabled case. That
left the branch's condition incomplete: any state not caught by branch 1
would fire exchange, even states that should not (e.g. organization
repos propagated from a parent without oauth_exchange set, which resolve
to an explicit nil).
Make both branches self-gated on the oauth_exchange flag so the
intent is local to each clause. Also clarify preflight comments in
remote_converger.