Improve CHANGELOG style against mardownlint#432
Conversation
|
Hum, I was always told that markdown lists should be indented, that's what we do in Elixir: https://github.com/elixir-lang/elixir/blob/master/lib/mix/lib/mix/project.ex#L42. Also the Elixir changelog: https://raw.githubusercontent.com/elixir-lang/elixir/master/CHANGELOG.md. I don't think the line length should be enforced because I will probably not enforce strictly in the future and I don't really see the point of it. The rest looks good 👍 |
I know, we can relax that rule if you want, at least in my case I find it useful to have that limit, that way I avoid to scroll so much in the terminal (e.g.
According to the original spec:
But again, we can relax that rule. |
Okay, lets enforce it in this PR and I will try to follow to the best of my ability in the future. But no promises :).
I think we indented lists originally because some python markdown renderer required it, but it should not matter in this case so let's dedent. If you remove the markdownlint file we are good to merge 👍 |
Thanks! |
|
Thank you! 😍 |
Refactored the Mint HTTP/2 connection-window patch from a narrow
`:connection_window_size` connect option into a proper public API,
`Mint.HTTP2.set_window_size(conn, target, new_size)`, that supports
both `:connection` and `{:request, ref}` and can be called at any point
after connect. Tracks the receive window in a new `receive_window_size`
field (connection and stream); grow-only; validated to `1..2^31-1`.
This is the function shape that fills a longstanding, well-known gap in
Mint's public API — upstream issue #357 (2022, closed) asked for exactly
this, #432 (2024, still open) is a related enhancement. Ready to submit
upstream as a PR.
On the hex side:
* Re-vendor from the integration branch (ericmj/hex-vendor-integration)
which has PR #478 (Elixir 1.12), PR #479 (HTTP/1 1xx handling) and
the new set_window_size/3 commit all stacked.
* `Conn.do_connect` now calls `Hex.Mint.HTTP2.set_window_size(conn,
:connection, 8_000_000)` immediately after a successful HTTP/2 connect.
No-op on HTTP/1. TCP ordering guarantees the WINDOW_UPDATE reaches the
server before any request HEADERS, so there's no extra RTT.
* `:client_settings: [initial_window_size: 8_000_000]` still handles the
per-stream initial window via SETTINGS.
* Update `scripts/vendor_mint.sh` comment block to point at the
integration branch and list all three upstream Mint patches with
branch links.
Refactored the Mint HTTP/2 connection-window patch from a narrow
`:connection_window_size` connect option into a proper public API,
`Mint.HTTP2.set_window_size(conn, target, new_size)`, that supports
both `:connection` and `{:request, ref}` and can be called at any point
after connect. Tracks the receive window in a new `receive_window_size`
field (connection and stream); grow-only; validated to `1..2^31-1`.
This is the function shape that fills a longstanding, well-known gap in
Mint's public API — upstream issue #357 (2022, closed) asked for exactly
this, #432 (2024, still open) is a related enhancement. Ready to submit
upstream as a PR.
On the hex side:
* Re-vendor from the integration branch (ericmj/hex-vendor-integration)
which has PR #478 (Elixir 1.12), PR #479 (HTTP/1 1xx handling) and
the new set_window_size/3 commit all stacked.
* `Conn.do_connect` now calls `Hex.Mint.HTTP2.set_window_size(conn,
:connection, 8_000_000)` immediately after a successful HTTP/2 connect.
No-op on HTTP/1. TCP ordering guarantees the WINDOW_UPDATE reaches the
server before any request HEADERS, so there's no extra RTT.
* `:client_settings: [initial_window_size: 8_000_000]` still handles the
per-stream initial window via SETTINGS.
* Update `scripts/vendor_mint.sh` comment block to point at the
integration branch and list all three upstream Mint patches with
branch links.
3 participants
This PR includes the following changes:
#) headerAlso, I added a basic configuration for mardownlint, but it's not necessary to be included in the repo, just let me know what do you think?