Don't delete docs when uploading docs with shared prefix #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private packages with a shared prefix, such that ecto is a prefix of ecto_sql, would delete the docs of ecto_sql when ecto was uploaded. This is because we list bucket files by prefix so that ecto/ would list all files under the ecto directory. The trailing / was removed by Path.join so we would also list the files of ecto_sql. This was only happened for private packages. Closes hexpm/hexpm#1252.
ericmj
force-pushed
the
ericmj/fix-path-join
branch
from
7f1c0de to
22a6888
Compare
wojtekmach
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private packages with a shared prefix, such that ecto is a prefix of ecto_sql, would delete the docs of ecto_sql when ecto was uploaded. This is because we list bucket files by prefix so that ecto/ would list all files under the ecto directory. The trailing / was removed by Path.join so we would also list the files of ecto_sql. This was only happened for private packages.
Closes hexpm/hexpm#1252.