Restrict organization names to underscores and hyphenate docs subdomains#1623
Merged
Conversation
Dependency ReviewThe following issues were found:
License Issuesmix.exs
OpenSSF Scorecard
Scanned Files
|
ericmj
force-pushed
the
org-subdomain-hyphens
branch
from
72e810f to
e7c44db
Compare
Organization docs move to per-org subdomains under hexorgs.pm, where the subdomain label maps `_` -> `-` (RFC 1123 / strict SAN matching). Tighten the org name charset from `^[a-z0-9_\-\.]+$` to `^[a-z0-9_]+$` so the `_` <-> `-` mapping is an exact bijection, mirroring package names. docs_html_url/3 now hyphenates the org repository name when building the subdomain (reusing the renamed name_to_subdomain/1 helper), so the generated documentation links point at the canonical host. The /api/repo test is updated to use an underscore org name, since hyphens are no longer valid.
ericmj
force-pushed
the
org-subdomain-hyphens
branch
from
e7c44db to
fba1488
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organization docs move to per-org subdomains under hexorgs.pm, where the subdomain label maps
_->-(RFC 1123 / strict SAN matching). Tighten the org name charset from^[a-z0-9_\-\.]+$to^[a-z0-9_]+$so the_<->-mapping is an exact bijection, mirroring package names.docs_html_url/3 now hyphenates the org repository name when building the subdomain (reusing the renamed name_to_subdomain/1 helper), so the generated documentation links point at the canonical host.
See hexpm/hexdocs#121.