Generating services incorrectly

[bhperry]

Description

Seems to be generating the ts services incorrectly.

In this screenshot, I have fixed the top service to the correct order (ThrowOnError first). The bottom one is as-generated.

Reproducible example or configuration

openapi.config.ts

import { defineConfig } from "@hey-api/openapi-ts";

export default defineConfig({
  client: '@hey-api/client-fetch',
  input: "../schemas/generated/routespec.yaml",
  output: {
    format: "prettier",
    lint: "eslint",
    path: "../frontend/src/types/generated/routes",
  },
  types: {
    dates: 'types+transform',
    enums: "javascript",
  },
  exportCore: false,
});

package.json

{
    "name": "openapi-generator",
    "version": "0.1.0",
    "private": true,
    "scripts": {
      "openapi-ts": "openapi-ts"
    },
    "dependencies": {
      "typescript": "^5.x"
    },
    "devDependencies": {
      "@hey-api/openapi-ts": "^0.52.3",
      "eslint": "^8.56.0",
      "prettier": "3.3.3"
    }
  }

generation command

npm run openapi-ts

OpenAPI specification (optional)

info:
  description: Notifications API test
  title: Notifications
  version: 2024.08.28
security:
- bearerAuth: []
paths:
  /api/notifications/subscriptions:
    delete:
      description: Unsubscribe a user from a notification topic
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/NotificationSubscriptionDelete'
      responses:
        '204':
          description: Ok
        '403':
          description: Access denied
    post:
      description: Subscribe a user to a notification topic
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/NotificationSubscription'
      responses:
        '200':
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/NotificationSubscription'
          description: Ok
        '403':
          description: Access denied
    get:
      description: Retrieve user notification subscriptions
      parameters:
      - in: query
        name: user_id
        schema:
          type: string
          nullable: true
        required: false
      - in: query
        name: topic
        schema:
          type: string
          nullable: true
        required: false
      - in: query
        name: last_key
        schema:
          type: string
          nullable: true
        required: false
      - in: query
        name: max_count
        schema:
          type: integer
          default: 100
          minimum: 1
          maximum: 1000
        required: false
      responses:
        '200':
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/NotificationSubscriptionsList'
          description: Ok
        '403':
          description: Access denied
openapi: 3.0.2
components:
  schemas:
    NotificationSubscriptionDelete:
      type: object
      properties:
        user_id:
          type: string
          nullable: true
        topic:
          type: string
      required:
      - topic
    NotificationSubscription:
      type: object
      properties:
        id:
          type: string
          readOnly: true
        user_id:
          type: string
          nullable: true
        topic:
          type: string
        options:
          nullable: true
      required:
      - topic
    NotificationSubscriptionsList:
      type: object
      properties:
        subscriptions:
          type: array
          readOnly: true
          items:
            $ref: '#/components/schemas/NotificationSubscription'
        next_last_key:
          type: string
          readOnly: true
          nullable: true
  securitySchemes:
    bearerAuth:
      type: http
      scheme: bearer

System information (optional)

npm: 9.8.1
node.js: v18.18.2

[mrlubos]

throwOnError is a feature of standalone clients and I don't see any listed in your dependencies, what's going on there? Can you ensure you're on the latest version of both openapi-ts and client-fetch?

[bhperry]

Our frontend is built on vue2 and has some other dependencies that are holding it back from upgrading typescript, etc. All of which makes it incompatible with @hey-api/openapi-ts. Currently working on upgrading to vue3 and removing old deps, but that is a slow process.

The package.json shown here is a standalone env used just for frontend code generation. Was previously using it just to generate types, which works fine, but I am now experimenting with generating the API client as well. There is a separate package.json for the actual frontend that has @hey-api/client-fetch installed.

Looks like I am a few minor versions behind on openapi-ts, I will try updating that and see if it fixes the issue. Do I also need to have client-fetch installed in the standalone openapi-generator env in order for it to work properly?

[mrlubos]

No, but I think I flipped the order of those arguments in one of the versions, so if you have the latest of both it should work

[bhperry]

Wonderful, thankyou. I will verify that tomorrow.

[bhperry]

Ok that worked, thanks for the help!