Skip to content

fix: return complete sse event in async iterator (#2641) #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: return complete sse event in async iterator (#2641) #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f6577a
fix: return complete sse event from generator (#2641)
Theo-Steiner Nov 19, 2025
2b94fd5
chore: commit generated examples
Theo-Steiner Nov 20, 2025
fdbe7a6
chore: add changeset
Theo-Steiner Nov 20, 2025
c3aba80
test: update tests to expect async iterator to return entire event
Theo-Steiner Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .changeset/clever-dragons-make.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
'@example/openapi-ts-tanstack-angular-query-experimental': patch
'@example/openapi-ts-tanstack-svelte-query': patch
'@example/openapi-ts-tanstack-react-query': patch
'@example/openapi-ts-tanstack-vue-query': patch
'@example/openapi-ts-angular-common': patch
'@example/openapi-ts-pinia-colada': patch
'@example/openapi-ts-angular': patch
'@example/openapi-ts-fastify': patch
'@example/openapi-ts-ofetch': patch
'@example/openapi-ts-openai': patch
'@example/openapi-ts-axios': patch
'@example/openapi-ts-fetch': patch
'@example/openapi-ts-next': patch
'@example/openapi-ts-ky': patch
'@hey-api/openapi-ts': patch
---

fix: return complete event in SSE async iterator (#2641)
8 changes: 6 additions & 2 deletions examples/openapi-ts-angular-common/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-angular/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-axios/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-fastify/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-fetch/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-ky/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-next/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-ofetch/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-openai/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
10 changes: 7 additions & 3 deletions examples/openapi-ts-pinia-colada/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
id: lastEventId
}

onSseEvent?.({
...baseSseEvent,
retry: retryDelay
})

if (dataLines.length) {
yield data as any
yield baseSseEvent as any
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions ...es/openapi-ts-tanstack-angular-query-experimental/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-tanstack-react-query/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions examples/openapi-ts-tanstack-svelte-query/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
10 changes: 7 additions & 3 deletions examples/openapi-ts-tanstack-vue-query/src/client/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
id: lastEventId
}

onSseEvent?.({
...baseSseEvent,
retry: retryDelay
})

if (dataLines.length) {
yield data as any
yield baseSseEvent as any
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions ...tests/main/test/__snapshots__/2.0.x/body-response-text-plain/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions ...ges/openapi-ts-tests/main/test/__snapshots__/2.0.x/form-data/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions ...st/__snapshots__/2.0.x/plugins/@angular/common/default-class/core/serverSentEvents.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,19 @@ export const createSseClient = <TData = unknown>({
}
}

onSseEvent?.({
const baseSseEvent = {
data,
event: eventName,
id: lastEventId,
};

onSseEvent?.({
...baseSseEvent,
retry: retryDelay,
});

if (dataLines.length) {
yield data as any;
yield baseSseEvent as any;
}
}
}
Expand Down
Loading
Loading