Skip to content

Conversation

@rigtigeEmil
Copy link

closes #3129

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Dec 22, 2025

@renoschubert is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

🦋 Changeset detected

Latest commit: 3935034

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug 🔥 Broken or incorrect behavior. labels Dec 22, 2025
@rigtigeEmil rigtigeEmil force-pushed the fix/client-nuxt-withrefs-nullable branch from ead94fb to 5e83fc0 Compare December 22, 2025 15:03
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 22, 2025
The WithRefs type was using NonNullable which stripped null from
nullable field types. This made it impossible to pass null values
to API endpoints that expect nullable fields (e.g., `street: null | string`).

Added `| Extract<TData[K], null>` to both branches of WithRefs to
preserve null in the union when the original type includes null.

Fixes: nullable fields in request body cannot be set to null
@rigtigeEmil rigtigeEmil force-pushed the fix/client-nuxt-withrefs-nullable branch from 5e83fc0 to 02f0305 Compare December 22, 2025 15:10
@rigtigeEmil rigtigeEmil reopened this Dec 30, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.83%. Comparing base (0c09e6c) to head (3935034).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
- Coverage   33.39%   32.83%   -0.57%     
==========================================
  Files         429      430       +1     
  Lines       33654    34126     +472     
  Branches     2156     2157       +1     
==========================================
- Hits        11238    11204      -34     
- Misses      22388    22894     +506     
  Partials       28       28              
Flag Coverage Δ
unittests 32.83% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rigtigeEmil rigtigeEmil force-pushed the fix/client-nuxt-withrefs-nullable branch 2 times, most recently from 6b56032 to a22a9f3 Compare December 30, 2025 21:28
@rigtigeEmil rigtigeEmil force-pushed the fix/client-nuxt-withrefs-nullable branch from a22a9f3 to 59ef4d6 Compare December 30, 2025 21:51
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@3131
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@3131
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@3131
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@3131

commit: 3935034

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@mrlubos mrlubos merged commit 929bab9 into hey-api:main Dec 31, 2025
20 of 23 checks passed
@hey-api hey-api bot mentioned this pull request Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Broken or incorrect behavior. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WithRefs type strips null from nullable fields

2 participants