Skip to content

Revert "Support async createClientConfig for per-request client configuration"#3480

Merged
mrlubos merged 2 commits intorevert-3445-copilot/support-async-create-client-configfrom
copilot/sub-pr-3479
Mar 3, 2026
Merged

Revert "Support async createClientConfig for per-request client configuration"#3480
mrlubos merged 2 commits intorevert-3445-copilot/support-async-create-client-configfrom
copilot/sub-pr-3479

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

Reverts #3445, removing async support from CreateClientConfig. The return type reverts from Config<...> | Promise<Config<...>> back to Config<...>.

Changes

  • Snapshot updates: Updated sse-tanstack-react-query snapshots to reflect the synchronous-only CreateClientConfig return type

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Mar 3, 2026 2:32am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 0b9e4b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert support async createClientConfig for per-request client configuration Revert "Support async createClientConfig for per-request client configuration" Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (revert-3445-copilot/support-async-create-client-config@83bfae0). Learn more about missing BASE report.

Additional details and impacted files
@@                                    Coverage Diff                                    @@
##             revert-3445-copilot/support-async-create-client-config    #3480   +/-   ##
=========================================================================================
  Coverage                                                          ?   40.30%           
=========================================================================================
  Files                                                             ?      483           
  Lines                                                             ?    17567           
  Branches                                                          ?     5328           
=========================================================================================
  Hits                                                              ?     7080           
  Misses                                                            ?     8431           
  Partials                                                          ?     2056           
Flag Coverage Δ
unittests 40.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos marked this pull request as ready for review March 3, 2026 02:47
@pullfrog
Copy link

pullfrog bot commented Mar 3, 2026

Error

agent completed without reporting progress

Pullfrog  | Rerun failed job ➔View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@mrlubos mrlubos merged commit 6671bc8 into revert-3445-copilot/support-async-create-client-config Mar 3, 2026
12 of 17 checks passed
@mrlubos mrlubos deleted the copilot/sub-pr-3479 branch March 3, 2026 02:47
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug 🔥 Broken or incorrect behavior. labels Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Broken or incorrect behavior. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants