Skip to content

refactor: cleaner length syntax#3645

Merged
mrlubos merged 1 commit intomainfrom
refactor/arr-length
Mar 25, 2026
Merged

refactor: cleaner length syntax#3645
mrlubos merged 1 commit intomainfrom
refactor/arr-length

Conversation

@mrlubos
Copy link
Copy Markdown
Member

@mrlubos mrlubos commented Mar 25, 2026

No description provided.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: afba377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review March 25, 2026 00:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Mar 25, 2026 1:03am

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 25, 2026

Error

agent completed without reporting progress

Pullfrog  | Rerun failed job ➔View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. internal ⚙️ Internal development work. labels Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 34.10853% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.00%. Comparing base (5399f76) to head (afba377).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts 16.66% 0 Missing and 10 partials ⚠️
...es/openapi-ts/src/plugins/orpc/shared/operation.ts 0.00% 3 Missing and 1 partial ⚠️
packages/openapi-ts/src/ts-dsl/stmt/if.ts 0.00% 1 Missing and 2 partials ⚠️
packages/openapi-ts/src/ts-dsl/stmt/try.ts 0.00% 1 Missing and 2 partials ⚠️
...s/src/plugins/@hey-api/typescript/v1/toAst/enum.ts 0.00% 0 Missing and 2 partials ⚠️
packages/openapi-ts/src/ts-dsl/decl/pattern.ts 0.00% 1 Missing and 1 partial ⚠️
packages/openapi-ts/src/ts-dsl/expr/postfix.ts 0.00% 1 Missing and 1 partial ⚠️
packages/openapi-ts/src/ts-dsl/expr/prefix.ts 0.00% 1 Missing and 1 partial ⚠️
packages/openapi-ts/src/ts-dsl/expr/template.ts 0.00% 1 Missing and 1 partial ⚠️
packages/openapi-ts/src/ts-dsl/expr/ternary.ts 0.00% 1 Missing and 1 partial ⚠️
... and 46 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3645   +/-   ##
=======================================
  Coverage   39.00%   39.00%           
=======================================
  Files         515      515           
  Lines       18891    18891           
  Branches     5594     5588    -6     
=======================================
  Hits         7368     7368           
  Misses       9318     9318           
  Partials     2205     2205           
Flag Coverage Δ
unittests 39.00% <34.10%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 25, 2026

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@3645

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@3645

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@3645

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@3645

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@3645

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@3645

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@3645

commit: afba377

@mrlubos mrlubos force-pushed the refactor/arr-length branch from 6482d51 to afba377 Compare March 25, 2026 01:02
@mrlubos mrlubos merged commit dd7f255 into main Mar 25, 2026
10 checks passed
@mrlubos mrlubos deleted the refactor/arr-length branch March 25, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant