Skip to content

fix(transformers): prevent additionalProperties transforms from affecting declared object properties#3646

Merged
mrlubos merged 4 commits intohey-api:mainfrom
codercms:fix/transformers-additional-properties
Mar 25, 2026
Merged

fix(transformers): prevent additionalProperties transforms from affecting declared object properties#3646
mrlubos merged 4 commits intohey-api:mainfrom
codercms:fix/transformers-additional-properties

Conversation

@codercms
Copy link
Copy Markdown
Contributor

Additional safeguard to changes introduced in #3409

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 25, 2026

Error

agent completed without reporting progress

Pullfrog  | Rerun failed job ➔View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 25, 2026

@codercms is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: 7e4050b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.99%. Comparing base (dd7f255) to head (7e4050b).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...api-ts/src/plugins/@hey-api/transformers/plugin.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3646      +/-   ##
==========================================
- Coverage   39.00%   38.99%   -0.01%     
==========================================
  Files         515      515              
  Lines       18891    18894       +3     
  Branches     5588     5595       +7     
==========================================
  Hits         7368     7368              
- Misses       9318     9320       +2     
- Partials     2205     2206       +1     
Flag Coverage Δ
unittests 38.99% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codercms codercms changed the title fix(transformers): prevent additonalProperties transforms to affect regular declared object properties fix(transformers): prevent additionalProperties transforms from affecting declared object properties Mar 25, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 25, 2026

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@3646

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@3646

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@3646

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@3646

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@3646

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@3646

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@3646

commit: 7e4050b

@mrlubos mrlubos force-pushed the fix/transformers-additional-properties branch from 1a17de5 to 3b2ea22 Compare March 25, 2026 03:20
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 25, 2026
@mrlubos mrlubos force-pushed the fix/transformers-additional-properties branch from 3b2ea22 to 7e4050b Compare March 25, 2026 03:24
Copy link
Copy Markdown
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I simpified the diff, will merge

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2026
@mrlubos mrlubos merged commit 43b9919 into hey-api:main Mar 25, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants