Skip to content

chore: remove package-lock.json files#3719

Merged
mrlubos merged 1 commit intomainfrom
chore/package-lock-delete
Apr 7, 2026
Merged

chore: remove package-lock.json files#3719
mrlubos merged 1 commit intomainfrom
chore/package-lock-delete

Conversation

@mrlubos
Copy link
Copy Markdown
Member

@mrlubos mrlubos commented Apr 7, 2026

No description provided.

@mrlubos mrlubos marked this pull request as ready for review April 7, 2026 02:25
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 7, 2026

Reviewed PR #3719 — approved. The three package-lock.json files are stale artifacts from Angular CLI scaffolding (ng new defaults to npm). Nothing in CI, scripts, or configs references them, and all dependencies are managed via the root pnpm-lock.yaml. Clean housekeeping change.

Task list (4/4 completed)
  • Read the PR diff to understand all changes
  • Check if any config or CI references these package-lock.json files
  • Verify .gitignore handles package-lock.json appropriately
  • Submit review

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 7, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Apr 7, 2026 2:25am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 7, 2026

⚠️ No Changeset found

Latest commit: 95d15f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 7, 2026

TL;DR — Removes stale package-lock.json files from three Angular examples. This is a pnpm monorepo, so npm lockfiles are unnecessary and can cause confusion or CI issues.

Key changes

  • Delete package-lock.json from Angular examples — Removes npm lockfiles from openapi-ts-angular-common, openapi-ts-angular, and openapi-ts-tanstack-angular-query-experimental since the repo uses pnpm for dependency management.

Summary | 3 files | 1 commit | base: mainchore/package-lock-delete

examples/openapi-ts-angular-common/package-lock.json · examples/openapi-ts-angular/package-lock.json · examples/openapi-ts-tanstack-angular-query-experimental/package-lock.json

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.24%. Comparing base (9f00629) to head (95d15f3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3719   +/-   ##
=======================================
  Coverage   40.24%   40.24%           
=======================================
  Files         520      520           
  Lines       19302    19302           
  Branches     5720     5726    +6     
=======================================
  Hits         7769     7769           
  Misses       9337     9337           
  Partials     2196     2196           
Flag Coverage Δ
unittests 40.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 7, 2026

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@3719

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@3719

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@3719

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@3719

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@3719

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@3719

commit: 95d15f3

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found.

Pullfrog  | View workflow run𝕏

@mrlubos mrlubos merged commit 716a6e8 into main Apr 7, 2026
12 checks passed
@mrlubos mrlubos deleted the chore/package-lock-delete branch April 7, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant