Skip to content

ci: gate release notes on changesets publish#3746

Merged
mrlubos merged 1 commit intomainfrom
ci/fix-changesets-publish-notes
Apr 13, 2026
Merged

ci: gate release notes on changesets publish#3746
mrlubos merged 1 commit intomainfrom
ci/fix-changesets-publish-notes

Conversation

@mrlubos
Copy link
Copy Markdown
Member

@mrlubos mrlubos commented Apr 13, 2026

No description provided.

@mrlubos mrlubos marked this pull request as ready for review April 13, 2026 05:28
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: c228824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Building Building Preview, Comment Apr 13, 2026 5:28am

Request Review

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 13, 2026
@mrlubos mrlubos merged commit a1eab87 into main Apr 13, 2026
3 of 4 checks passed
@dosubot dosubot Bot added the internal ⚙️ Internal development work. label Apr 13, 2026
@mrlubos mrlubos deleted the ci/fix-changesets-publish-notes branch April 13, 2026 05:28
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found.

Task list (4/4 completed)
  • Checkout PR and read the diff
  • Analyze the CI workflow change and verify correctness
  • Self-critique drafted comments
  • Submit review

Pullfrog  | View workflow run𝕏

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 13, 2026

TL;DR — Gates the release notes generation and GitHub release creation steps on whether changesets/action actually published packages, preventing failures when the action only creates a release PR without publishing.

Key changes

  • Gate release notes steps on changesets publish output — Adds an id to the changesets/action step and conditions the downstream "Generate Release Tag", "Generate Release Notes", and "Create GitHub Release" steps on steps.changesets.outputs.published == 'true', so they only run after a real publish.

Summary | 1 file | 1 commit | base: mainci/fix-changesets-publish-notes

Previously, the release tag generation, release notes generation, and GitHub release creation ran unconditionally after changesets/action. When the action created a release PR instead of publishing, these steps would fail because there was no new tag or changelog to process. The id: changesets addition exposes the action's published output, and the three if guards ensure those steps are skipped on PR-only runs.

.github/workflows/release.yml

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.04%. Comparing base (4cfc177) to head (c228824).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3746   +/-   ##
=======================================
  Coverage   40.04%   40.04%           
=======================================
  Files         520      520           
  Lines       19243    19243           
  Branches     5726     5726           
=======================================
  Hits         7705     7705           
  Misses       9342     9342           
  Partials     2196     2196           
Flag Coverage Δ
unittests 40.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant