Skip to content

ci: set token explicitly instead of using env#3760

Merged
mrlubos merged 1 commit intomainfrom
ci/release-token-value
Apr 14, 2026
Merged

ci: set token explicitly instead of using env#3760
mrlubos merged 1 commit intomainfrom
ci/release-token-value

Conversation

@mrlubos
Copy link
Copy Markdown
Member

@mrlubos mrlubos commented Apr 14, 2026

No description provided.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review April 14, 2026 00:21
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: 45f7d94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Building Building Preview, Comment Apr 14, 2026 0:21am

Request Review

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 14, 2026
@mrlubos mrlubos merged commit 1186d92 into main Apr 14, 2026
8 of 9 checks passed
@mrlubos mrlubos deleted the ci/release-token-value branch April 14, 2026 00:21
@dosubot dosubot bot added the internal ⚙️ Internal development work. label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found.

Task list (3/3 completed)
  • Read the PR diff
  • Analyze the change and check for issues
  • Submit review

Pullfrog  | View workflow run𝕏

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Apr 14, 2026

TL;DR — Switches the GitHub release step from passing the token via the GITHUB_TOKEN environment variable to using the action's explicit token input parameter, which is the recommended way to authenticate with actions/create-release (or the underlying API call).

Key changes

  • Use token input instead of GITHUB_TOKEN env var for release creation — Replaces the env.GITHUB_TOKEN block with the token parameter directly on the action step, ensuring the app token is passed explicitly rather than through the environment.

Summary | 1 file | 1 commit | base: mainci/release-token-value

This is a single-feature PR — the change is minimal and self-contained.

Before: The app token was set as the GITHUB_TOKEN environment variable on the release step.
After: The app token is passed directly via the token input parameter.

This aligns with the standard pattern for GitHub Actions that accept authentication tokens as explicit inputs rather than relying on environment variables.

.github/workflows/release.yml

Pullfrog  | View workflow run | Triggered by Pullfrog𝕏

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.08%. Comparing base (fe08b45) to head (45f7d94).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
- Coverage   40.11%   40.08%   -0.03%     
==========================================
  Files         521      521              
  Lines       19261    19273      +12     
  Branches     5733     5727       -6     
==========================================
  Hits         7726     7726              
- Misses       9339     9345       +6     
- Partials     2196     2202       +6     
Flag Coverage Δ
unittests 40.08% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant