Skip to content

ci: fix changelog#3799

Merged
mrlubos merged 1 commit intomainfrom
ci/fix-changelog
Apr 20, 2026
Merged

ci: fix changelog#3799
mrlubos merged 1 commit intomainfrom
ci/fix-changelog

Conversation

@mrlubos
Copy link
Copy Markdown
Member

@mrlubos mrlubos commented Apr 20, 2026

No description provided.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review April 20, 2026 21:04
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

⚠️ No Changeset found

Latest commit: 5caa441

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Apr 20, 2026 9:19pm

Request Review

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. internal ⚙️ Internal development work. labels Apr 20, 2026
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 20, 2026

TL;DR — The release workflow was running changelog:assemble during changeset version, before packages were published — so the changelog couldn't reference the actual release tag or commits. This PR decouples changelog generation into a dedicated post-publish step, ensures full git history is available for diffing, and adds the missing 2026-04-20 changelog entry.

Key changes

  • Decouple changelog assembly from changeset version — the version command now runs plain changeset version; a new post-publish "Rebuild changelog" step calls pnpm changelog:assemble and a follow-up step auto-commits the result. The changelog:version script is removed from package.json.
  • Enable full git history in release workflow — adds fetch-depth: 0 and fetch-tags: true to the checkout action so the changelog generator can compute diffs from the latest tag.
  • Move CURRENT_BRANCH to job-level env — replaces the shell step that ran git branch --show-current with ${{ github.ref_name }} set once at the top.
  • Add 2026-04-20 changelog entry — documents releases for @hey-api/openapi-ts 0.96.1, @hey-api/json-schema-ref-parser 1.4.1, @hey-api/shared 0.4.1, and @hey-api/vite-plugin 0.3.1.
  • Normalize step name casing — lowercases step names throughout the workflow for consistency.

Summary | 3 files | 1 commit | base: mainci/fix-changelog


Decoupled changelog assembly

Before: changelog:version ran changeset version && pnpm changelog:assemble in the version step — before packages were published, so the changelog script lacked the release tag context it needed.
After: version runs only changeset version. A new "Rebuild changelog" step runs pnpm changelog:assemble after publish, and a "Commit changelog" step auto-commits CHANGELOG.md with [skip ci].

The changelog:version compound script is removed from package.json since it is no longer needed. The CURRENT_BRANCH env var is now derived from github.ref_name at the job level instead of a dedicated shell step.

.github/workflows/release.yml · package.json · CHANGELOG.md

Pullfrog  | View workflow run | via Pullfrog𝕏

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.80%. Comparing base (aaba2d9) to head (5caa441).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3799   +/-   ##
=======================================
  Coverage   39.80%   39.80%           
=======================================
  Files         530      530           
  Lines       19467    19467           
  Branches     5797     5791    -6     
=======================================
  Hits         7748     7748           
  Misses       9487     9487           
  Partials     2232     2232           
Flag Coverage Δ
unittests 39.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found.

Task list (3/3 completed)
  • Read the diff to understand changes
  • Investigate context: existing release workflow and changelog patterns
  • Draft and submit review

Pullfrog  | View workflow run𝕏

@mrlubos mrlubos merged commit 6cf6b1a into main Apr 20, 2026
11 checks passed
@mrlubos mrlubos deleted the ci/fix-changelog branch April 20, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant