fix(core): inline and preserve sub-composition scripts in preview bundles#1068
Merged
miguel-heygen merged 3 commits intoMay 25, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| export function wrapInlineScriptWithErrorBoundary(source: string, errorLabel: string): string { | ||
| return `(function(){ try { Function(${JSON.stringify(source)}).call(window); } catch (_err) { console.error(${JSON.stringify(errorLabel)}, _err); } })();`; |
| } | ||
|
|
||
| export function wrapInlineScriptWithErrorBoundary(source: string, errorLabel: string): string { | ||
| return `(function(){ try { Function(${JSON.stringify(source)}).call(window); } catch (_err) { console.error(${JSON.stringify(errorLabel)}, _err); } })();`; |
miguel-heygen
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix preview bundling for sub-compositions that reference local scripts.
Makes preview bundles inline local sub-composition scripts and preserve authored script order, so required component/runtime scripts are available before inline scene scripts run.
Why
Preview bundling had two related issues:
These bugs caused preview-only runtime failures such as HTML being parsed as JS and component globals being undefined.
How
Test plan
How was this tested?