test(cli): cover cloud reportApiError hint cascade#1131
Merged
miguel-heygen merged 1 commit intoMay 31, 2026
Conversation
reportApiError centralizes the HyperframesApiError -> Error -> String reporting cascade for the cloud subverbs, including the curated ERROR_CODE_HINTS table and its priority order (code-specific hint > caller suggestion > bare code label > no third line). That priority logic was previously untested; the module comment notes a past regression where hyperframes_render_not_found was unreachable from get/delete. Add errors.test.ts covering: 404 + notFound short-circuit, known-code hint, hint-wins-over-suggestion priority, suggestion fallback, bare code label, no-third-line, extraHints merge and override, plain Error, and non-Error stringification. Mocks errorBox and process.exit following the sibling cloud/parsing.test.ts pattern.
miguel-heygen
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
packages/cli/src/cloud/errors.test.tscoveringreportApiError, the shared error reporter for thecloud render/list/get/deletesubverbs.Why
reportApiErrorcentralizes theHyperframesApiError→Error→Stringcascade and applies the curatedERROR_CODE_HINTStable with a specific priority order: code-specific hint > caller suggestion > bare code label > no third line. That priority logic was the only file incloud/without test coverage, and the module comment notes a past regression (review finding 10) wherehyperframes_render_not_foundwas unreachable fromget/delete. These tests pin the cascade so that class of regression is caught.Coverage
Ten cases:
notFoundoption short-circuits to a "Not found" boxERROR_CODE_HINTSentrysuggestionsuggestionfallback when the code has no hintcode: <code>label when there is no hint and no suggestionextraHintsmerges on top of the built-in table, and overrides a built-in entryErrorreported with the stage title and suggestionErrorthrown value stringifiederrorBoxandprocess.exitare mocked following the existing sibling pattern incloud/parsing.test.ts. No source changes. Fullcloud/suite passes (46/46).