fix(engine,cli): render command improvements - headless-shell fallback, better errors#135
Closed
miguel-heygen wants to merge 3 commits intomainfrom
Closed
fix(engine,cli): render command improvements - headless-shell fallback, better errors#135miguel-heygen wants to merge 3 commits intomainfrom
miguel-heygen wants to merge 3 commits intomainfrom
Conversation
mkdirSync for the render output path was not wrapped in try-catch, exposing a raw Node.js EACCES stack trace when the path was invalid or permissions were denied. Reproducer: npx hyperframes render --output /root/nope/output.mp4 # Was: raw "Error: EACCES: permission denied" with stack trace # Now: clean "Cannot create output directory" error box
When a composition had zero duration (empty GSAP timeline, no data-duration), Docker render hung for 45s then showed the misleading hint "Check Docker is running" even though Docker was fine. Now detects the __hf-not-ready error and suggests adding data-duration or GSAP tweens instead. Reproducer: # Create composition with empty timeline and no data-duration npx hyperframes render --docker --output out.mp4 # Was: "Check Docker is running: docker info" # Now: "Composition may have zero duration. Add data-duration..."
…eadless-shell The engine assumed any binary passed via PRODUCER_HEADLESS_SHELL_PATH supported the HeadlessExperimental.beginFrame CDP command. When the CLI resolved system Chrome (e.g. /usr/bin/google-chrome) instead of chrome-headless-shell, the render would silently hang for 120s then timeout — the #1 new-user friction point. Now checks the binary path for "chrome-headless-shell" before selecting beginframe capture mode. System Chrome falls back to screenshot mode which works universally. Reproducer: # On a machine with system Chrome but no chrome-headless-shell cached npx hyperframes init test --template blank --non-interactive cd test && npx hyperframes render --output out.mp4 # Was: 120s hang, then "Timed out after waiting 120000ms" # Now: renders successfully via screenshot mode
miguel-heygen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates PRs #129, #130, #131.
🤖 Generated with Claude Code