fix(cli): CLI polish — info command dimensions, all templates, non-TTY ANSI codes#136
Closed
miguel-heygen wants to merge 3 commits intomainfrom
Closed
fix(cli): CLI polish — info command dimensions, all templates, non-TTY ANSI codes#136miguel-heygen wants to merge 3 commits intomainfrom
miguel-heygen wants to merge 3 commits intomainfrom
Conversation
The info command was hardcoding dimensions based on portrait/landscape detection, which defaulted to portrait because parseHtml() doesn't read data-width/data-height from composition root elements. Now reads the actual attribute values from the HTML. Reproducer: npx hyperframes init test --template blank --non-interactive cd test && npx hyperframes info # Shows "1080x1920" (portrait) but index.html has data-width="1920" data-height="1080"
The decision-tree, kinetic-type, product-promo, and nyt-graph templates existed in source but were not copied to dist/templates/ during build. Users selecting these templates from init --help got an unhandled ENOENT crash with a raw Node.js stack trace. Reproducer: npx hyperframes init test --template decision-tree --non-interactive # Crashes: Error: ENOENT: no such file or directory, lstat '.../dist/templates/decision-tree'
renderProgress() was writing \r\x1b[2K escape codes even when stdout is not a TTY, corrupting output for CI pipelines and AI agents. Now writes clean text lines at 10% intervals when not a TTY. Reproducer: cd my-video npx hyperframes render --output out.mp4 2>&1 | cat # Output contained raw escape codes: \x1b[2K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyperframes inforeads actualdata-width/data-heightattributesConsolidates PRs #122, #123, #124.
🤖 Generated with Claude Code