Skip to content

fix(ci): use NPM_TOKEN secret for npm publish auth#15

Merged
jrusso1020 merged 1 commit intomainfrom
fix/publish-npm-token
Mar 23, 2026
Merged

fix(ci): use NPM_TOKEN secret for npm publish auth#15
jrusso1020 merged 1 commit intomainfrom
fix/publish-npm-token

Conversation

@jrusso1020
Copy link
Copy Markdown
Collaborator

@jrusso1020 jrusso1020 commented Mar 23, 2026

What

Fix publish workflow — use Node.js 24 instead of 22 for npm trusted publishing.

Why

npm Trusted Publishing (OIDC) requires npm CLI >= 11.5.1. Node.js 22 ships with npm v10, which doesn't support the OIDC handshake. When the handshake fails, npm treats the request as anonymous and returns a misleading 404.

Node.js 24 ships with npm v11, which supports trusted publishing natively.

How

  • Changed node-version: 22node-version: 24 in the publish workflow only
  • Removed the NPM_TOKEN / NODE_AUTH_TOKEN workaround (not needed with OIDC)
  • CI workflow stays on Node 22 (doesn't need npm publish)
  • No secrets required — OIDC handles auth via the trusted publisher config on npmjs.com

References

Test plan

  • After merge, delete v0.1.1 tag and re-push to test publish

@jrusso1020 jrusso1020 force-pushed the fix/publish-npm-token branch from c65fd6f to 3fe9267 Compare March 23, 2026 03:35
@jrusso1020 jrusso1020 merged commit edd1c02 into main Mar 23, 2026
7 checks passed
@jrusso1020 jrusso1020 deleted the fix/publish-npm-token branch March 23, 2026 03:36
miguel-heygen added a commit that referenced this pull request Apr 7, 2026
## Summary

Adds critical rendering constraints to the `hyperframes` skill discovered from eval analysis of 27 agent-generated compositions. These guardrails prevent agents from producing compositions that technically work but render poorly.

## What it fixes

| Rule Added | Eval Prompts Affected | Issue |
| --- | --- | --- |
| Ban `repeat: -1` | #20 loading-spinner (2.0/5) | Infinite timeline broke capture engine |
| Ban async timeline construction | #16 particle-logo (2.6/5) | Timeline empty at capture time |
| Min font size 16px (labels), 20px (body) | #7, #8, #13, #14, #15, #19 | Illegible text after encoding |
| Ban full-screen dark linear gradients | #3, #5, #10, #14 | H.264 color banding |
| `<link>` fonts over CSS `@import` | #7, #24 | Font loading race conditions |

## Changes

- **Rules section**: Added `repeat: -1` ban, async timeline ban, items 8-9 to "Never do" list
- **Typography section**: Expanded font size guidance with specific minimums per text role (headlines, body, labels)
- **New "Backgrounds and Color" section**: Guidance on avoiding gradient banding
- **Output Checklist**: 5 new items covering all new constraints

## Test plan

- [ ] Run eval with updated skill and compare avg quality scores
- [x] Skill renders correctly in `/hyperframes` invocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant