feat(engine): frame-capture core — fast-capture routing, worker-encode, dedup extension#1919
Open
vanceingalls wants to merge 1 commit into
Open
feat(engine): frame-capture core — fast-capture routing, worker-encode, dedup extension#1919vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
…e, dedup extension
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Frame-capture core — routing, worker-encode, static-dedup unification (stack 4/6)
The heart of the feature. Wires drawElement capture (2/6) + the risk gate (3/6) into the capture loop, adds worker-offloaded encode, and unifies our static-frame dedup with the implementation main shipped independently.
packages/engine/src/services/frameCapture.ts(+714 / −33)detectCssEffectRisk) that routes incompatible comps to the screenshot baseline.produceDrawElementFrame); frees the main thread so capture (paint-wait + readback), not encode, is the throughput bound.No cached paint record, clip-cut boundary) falls back to a screenshot for that frame instead of aborting the render.mainand this branch each independently implemented static-frame dedup with the same symbol names. This PR keeps main's implementation as canonical (default-onconfig.staticFrameDedup, clip-start safety, density-verify backstop, observability) and extends it to the drawElement + worker-encode path — worker-path frame reuse (lastEncodeResult) + blank-frame detection (deFrameSizes), armed on the drawElement-proceed site (pre-canvas-injection, so main's screenshot-based density-verify remains a valid backstop for the DE path). Our opt-inHF_STATIC_DEDUPenv is dropped — superseded by main's single default-on config switch governing both capture modes. Net behavior change: static-dedup is now default-on for both screenshot and drawElement paths.Also:
browserManager.ts,screenshotService.ts,index.ts(exports/glue).Stack: #1916 → #1917 → #1918 → #1919 (here) → #1920 → #1921. Rebased onto current
main; supersedes #1295 + #1444. Intermediate PRs don't compile independently — feature green at the tip (#1921), tsc-clean + 231 tests pass.🤖 Generated with Claude Code