fix(producer): handle no-audio source files in resolveMediaDuration#560
Merged
miguel-heygen merged 1 commit intomainfrom Apr 29, 2026
Merged
fix(producer): handle no-audio source files in resolveMediaDuration#560miguel-heygen merged 1 commit intomainfrom
miguel-heygen merged 1 commit intomainfrom
Conversation
When an <audio> element referenced a file with no audio stream (e.g. a
silent screen-recording used as an audio src, or a video-only clip),
extractAudioMetadata threw "[FFmpeg] No audio stream found". The error
propagated uncaught through Promise.all in compileHtmlFile and crashed
the entire render.
Apply the same graceful-skip pattern already used for missing files and
failed downloads: catch the probe error and return { duration: 0 } so
the element is excluded from the composition without aborting the render.
Confirmed via 7 production HyperframeRenderWorkflow failures all sharing
the same TemporalMagicEditActivity.RENDER_PREVIEW stack trace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an
<audio>element referenced a file with no audio stream (e.g. a silent video used as an audio src),resolveMediaDurationcalledextractAudioMetadatawithout a guard.ffprobethrew[FFmpeg] No audio stream found, which propagated uncaught throughPromise.allincompileHtmlFileand crashed the entire render.What this fixes
Wraps the
extractAudioMetadataprobe in a try-catch insideresolveMediaDuration. On failure the function returns{ duration: 0 }, so the element is excluded from the composition gracefully — the same pattern already used for missing files and failed HTTP downloads.How
packages/producer/src/services/htmlCompiler.ts—resolveMediaDuration():