feat: add vertical flowchart block#563
Merged
miguel-heygen merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
jrusso1020
approved these changes
Apr 29, 2026
Collaborator
jrusso1020
left a comment
There was a problem hiding this comment.
LGTM — clean portrait variant for issue #558.
Quality checks:
- Root has
data-composition-id="flowchart-vertical", distinct from the landscapeflowchart(so both can coexist in a project) - 1440×2560 dimensions match the registry-item.json declaration
- All 19 GSAP selectors use string concatenation (
S + " #node-X"); zero template literals — passestemplate_literal_selectorlint rule out of the box (relevant because that's the same lint rule the existing landscapeflowchartblock tripped per issue #559, fixed in #564) window.__timelines["flowchart-vertical"] = tl;registered correctly- 12s duration matches the GSAP timeline structure (intro through fade-out)
— Review by Rames Jusso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #558.
The catalog only had a 1920x1080
flowchartblock. Vertical short-form projects targeting 1440x2560 had to either avoid the block or letterbox/stretch a landscape composition.What this fixes
flowchart-verticalregistry block at 1440x2560.registry-item.jsonso catalog/install flows can address the portrait block by name.Root cause
The existing
flowchartblock hard-codes landscape dimensions and geometry. A parent composition cannot override the child block'sdata-width,data-height, SVG viewBox, or node positions from outside the block.Verification
Local checks
bunx oxfmt --check registry/blocks/flowchart-vertical/flowchart-vertical.html registry/blocks/flowchart-vertical/registry-item.jsonbunx oxlint registry/blocks/flowchart-vertical/flowchart-vertical.html-> 0 files inspected by oxlint, no errorsregistry/blocks/flowchart-vertical/flowchart-vertical.html-> 0 errors, 1 existingcomposition_file_too_largewarning, 1 external script infobun run build:hyperframes-runtimebun run --filter @hyperframes/cli dev -- lint /tmp/hf-flowchart-vertical-qa-> 0 errors, 1 existingcomposition_file_too_largewarningBrowser verification
/tmp/hf-flowchart-vertical-qaembeddingcompositions/flowchart-vertical.html.http://localhost:5190withagent-browser.qa-artifacts/issue-558/flowchart-vertical-3s.pngqa-artifacts/issue-558/flowchart-vertical-playback.webmNotes
The
composition_file_too_largewarning is inherited from the current catalog/linter policy for large single-file blocks. Splitting the flowchart into smaller sub-compositions would be a broader catalog refactor, so this PR keeps the new block structurally aligned with the existingflowchartitem.