Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/producer/src/services/render/stages/compileStage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
* `deviceScaleFactor` for supersampling.
*
* The probe sub-stage (browser launch, duration discovery, recompile,
* media reconciliation) is extracted separately in PR 1.3. This stage
* stops at the point where the in-process renderer formerly entered the
* `if (needsBrowser)` branch.
* media reconciliation) lives in a sibling stage. This stage stops at
* the point where the in-process renderer enters the `if (needsBrowser)`
* branch.
*
* Hard constraints preserved verbatim from the in-process renderer:
* - `applyRenderModeHints(cfg, ...)` is allowed to mutate `cfg.forceScreenshot`.
Expand Down
19 changes: 7 additions & 12 deletions packages/producer/src/services/render/stages/freezePlan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
* manifest at the end of `plan()`, compute the planHash from the frozen
* artifacts, and return the manifest path.
*
* Phase 1 PR 1.1 ships the signature only: there are no callers yet. The
* function body is added in Phase 3 PR 3.1 when `services/distributed/plan.ts`
* lands and composes the Phase-1 stages. Keeping the skeleton in this PR
* means subsequent stage-extraction PRs can grow the `stages/` directory
* without touching the `producer/src/index.ts` export surface again.
* Signature-only skeleton: there are no callers yet. The function body
* lands when `services/distributed/plan.ts` is added and composes the
* stage primitives.
*
* See DISTRIBUTED-RENDERING-PLAN.md §2.1 phase 6, §4.1 directory layout,
* §4.3 LockedRenderConfig.
Expand All @@ -18,9 +16,7 @@ import type { PlanDimensions } from "./planHash.js";

/**
* The encoder configuration locked in at plan time. Mirrors §4.3
* LockedRenderConfig in the design doc. Phase 1 declares the shape; Phase 2
* + Phase 3 populate it from the existing `renderOrchestrator` config and
* the new closed-GOP encoder args.
* LockedRenderConfig in the design doc.
*/
export interface LockedRenderConfig {
// Capture
Expand Down Expand Up @@ -97,10 +93,9 @@ export interface FreezePlanResult {
* Freeze a plan directory: write `meta/*.json` + top-level `plan.json`, then
* compute `planHash` over the canonicalized contents.
*
* Skeleton only in Phase 1. Phase 3 PR 3.1 wires this up.
* Skeleton — body lands when the distributed-render primitives compose the
* stage functions.
*/
export async function freezePlan(_input: FreezePlanInput): Promise<FreezePlanResult> {
throw new Error(
"freezePlan is not implemented yet — wired in Phase 3 PR 3.1 (see DISTRIBUTED-RENDERING-PLAN.md §11).",
);
throw new Error("freezePlan is not implemented yet — see DISTRIBUTED-RENDERING-PLAN.md §11.");
}
Loading
Loading