fix(studio): prevent composition switch loop on sub-composition navigation#754
Merged
Merged
Conversation
…ation Circular state update between activeCompPath and compositionStack caused the preview to flicker when navigating to sub-compositions and scrubbing. The cycle: activeCompPath change → useEffect updates compositionStack → onCompositionChange fires → setActiveCompPath + refreshPreviewDocumentVersion → re-render → effect re-evaluates → repeat. Fixed by guarding both sides: onCompositionChange skips if path unchanged, updateCompositionStack skips notification if top-of-stack ID unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
miguel-heygen
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Circular state update between
activeCompPathandcompositionStackcaused the preview to flicker when navigating to sub-compositions and scrubbing.The cycle:
activeCompPathchange → useEffect updatescompositionStack→onCompositionChangefires →setActiveCompPath+refreshPreviewDocumentVersion→ re-render → effect re-evaluates → repeat.Fix: Guard both sides of the cycle:
onCompositionChangeinStudioPreviewAreaskips ifcompPath === activeCompPathupdateCompositionStackinNLELayoutskipsonCompositionChangenotification if top-of-stack ID unchangedTest plan
data-composition-src)🤖 Generated with Claude Code