experiment: studio bare-version revert only — does Windows CI go green?#780
Closed
jrusso1020 wants to merge 1 commit into
Closed
experiment: studio bare-version revert only — does Windows CI go green?#780jrusso1020 wants to merge 1 commit into
jrusso1020 wants to merge 1 commit into
Conversation
…nges Smallest-fix hypothesis test for the Windows CI regression introduced by PR #748. That PR changed `packages/studio/package.json` from caret/union ranges to bare-version exact pins. Reverting just those 4 lines may be sufficient to restore the pre-PR #748 working state. Also includes the format fix that's blocking all CI on main.
Collaborator
Author
|
Closing — experiment result. Reverting studio's bare-version pins alone does not fix Windows CI. Same original failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment, not intended for merge.
Testing the smallest-possible-fix hypothesis from #778's investigation. PR #748 changed studio's package.json from caret/union ranges to bare-version exact pins. If those bare-version specs are what flipped bun's resolver into a layout Windows can't materialize, this 4-line revert may be the only thing needed.
Compare to #778 (full fix: dep alignment + workflow change + source rewrites). If this experiment is green, #778 is overengineered.
Changes
@codemirror/view,@types/react,@types/react-dom,react,react-domspecs inpackages/studio/package.jsonto their pre-PR refactor(studio): contexts, PropertyPanel split, duration fix, perf #748 values