Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 94 additions & 0 deletions packages/studio/src/player/store/playerStore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,100 @@ describe("usePlayerStore", () => {
});
});

describe("setInPoint", () => {
it("updates inPoint", () => {
usePlayerStore.getState().setInPoint(1.5);
expect(usePlayerStore.getState().inPoint).toBe(1.5);
});

it("clears inPoint when given null", () => {
usePlayerStore.getState().setInPoint(1.5);
usePlayerStore.getState().setInPoint(null);
expect(usePlayerStore.getState().inPoint).toBeNull();
});

it("rejects non-finite values", () => {
usePlayerStore.getState().setInPoint(Number.NaN);
expect(usePlayerStore.getState().inPoint).toBeNull();
});

it("nullifies outPoint when new inPoint is at or past existing outPoint", () => {
usePlayerStore.getState().setOutPoint(2);
usePlayerStore.getState().setInPoint(3);
expect(usePlayerStore.getState().outPoint).toBeNull();
expect(usePlayerStore.getState().inPoint).toBe(3);
});

it("preserves outPoint when new inPoint is before it", () => {
usePlayerStore.getState().setOutPoint(5);
usePlayerStore.getState().setInPoint(2);
expect(usePlayerStore.getState().outPoint).toBe(5);
});

it("auto-enables loopEnabled when set to a non-null value", () => {
usePlayerStore.getState().setLoopEnabled(false);
usePlayerStore.getState().setInPoint(1.5);
expect(usePlayerStore.getState().loopEnabled).toBe(true);
});

it("preserves loopEnabled when cleared with null", () => {
usePlayerStore.getState().setLoopEnabled(true);
usePlayerStore.getState().setInPoint(null);
expect(usePlayerStore.getState().loopEnabled).toBe(true);

usePlayerStore.getState().setLoopEnabled(false);
usePlayerStore.getState().setInPoint(null);
expect(usePlayerStore.getState().loopEnabled).toBe(false);
});
});

describe("setOutPoint", () => {
it("updates outPoint", () => {
usePlayerStore.getState().setOutPoint(4.2);
expect(usePlayerStore.getState().outPoint).toBe(4.2);
});

it("clears outPoint when given null", () => {
usePlayerStore.getState().setOutPoint(4.2);
usePlayerStore.getState().setOutPoint(null);
expect(usePlayerStore.getState().outPoint).toBeNull();
});

it("rejects non-finite values", () => {
usePlayerStore.getState().setOutPoint(Number.POSITIVE_INFINITY);
expect(usePlayerStore.getState().outPoint).toBeNull();
});

it("nullifies inPoint when new outPoint is at or before existing inPoint", () => {
usePlayerStore.getState().setInPoint(5);
usePlayerStore.getState().setOutPoint(3);
expect(usePlayerStore.getState().inPoint).toBeNull();
expect(usePlayerStore.getState().outPoint).toBe(3);
});

it("preserves inPoint when new outPoint is after it", () => {
usePlayerStore.getState().setInPoint(2);
usePlayerStore.getState().setOutPoint(5);
expect(usePlayerStore.getState().inPoint).toBe(2);
});

it("auto-enables loopEnabled when set to a non-null value", () => {
usePlayerStore.getState().setLoopEnabled(false);
usePlayerStore.getState().setOutPoint(4.2);
expect(usePlayerStore.getState().loopEnabled).toBe(true);
});

it("preserves loopEnabled when cleared with null", () => {
usePlayerStore.getState().setLoopEnabled(true);
usePlayerStore.getState().setOutPoint(null);
expect(usePlayerStore.getState().loopEnabled).toBe(true);

usePlayerStore.getState().setLoopEnabled(false);
usePlayerStore.getState().setOutPoint(null);
expect(usePlayerStore.getState().loopEnabled).toBe(false);
});
});

describe("setTimelineReady", () => {
it("updates timelineReady", () => {
usePlayerStore.getState().setTimelineReady(true);
Expand Down
4 changes: 4 additions & 0 deletions packages/studio/src/player/store/playerStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ export const usePlayerStore = create<PlayerState>((set) => ({
inPoint: t,
outPoint:
t !== null && state.outPoint !== null && t >= state.outPoint ? null : state.outPoint,
// Setting a work-area marker implies the user wants playback bounded by it.
// Auto-enable loop so the playhead respects the marker instead of running past.
loopEnabled: t !== null ? true : state.loopEnabled,
};
}),
setOutPoint: (time) =>
Expand All @@ -135,6 +138,7 @@ export const usePlayerStore = create<PlayerState>((set) => ({
return {
outPoint: t,
inPoint: t !== null && state.inPoint !== null && t <= state.inPoint ? null : state.inPoint,
loopEnabled: t !== null ? true : state.loopEnabled,
};
}),
setManualZoomPercent: (percent) =>
Expand Down
Loading