Skip to content

fix: ship lottieReadiness + guard studio import.meta.env for non-Vite consumers #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 2 commits into from
May 16, 2026
Merged

fix: ship lottieReadiness + guard studio import.meta.env for non-Vite consumers #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3270908
fix(core): move lottieReadiness out of src/runtime so it ships in dist
terencecho May 15, 2026
4426ffa
fix(studio): guard import.meta.env for non-Vite consumers
terencecho May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
},
"./runtime": "./dist/hyperframe.runtime.iife.js",
"./runtime/lottie-readiness": {
"import": "./src/runtime/adapters/lottieReadiness.ts",
"types": "./src/runtime/adapters/lottieReadiness.ts"
"import": "./src/lottieReadiness.ts",
"types": "./src/lottieReadiness.ts"
},
"./studio-api": {
"import": "./src/studio-api/index.ts",
Expand Down Expand Up @@ -78,8 +78,8 @@
},
"./runtime": "./dist/hyperframe.runtime.iife.js",
"./runtime/lottie-readiness": {
"import": "./dist/runtime/adapters/lottieReadiness.js",
"types": "./dist/runtime/adapters/lottieReadiness.d.ts"
"import": "./dist/lottieReadiness.js",
"types": "./dist/lottieReadiness.d.ts"
},
"./studio-api": {
"import": "./dist/studio-api/index.js",
Expand Down
0 .../runtime/adapters/lottieReadiness.test.ts → packages/core/src/lottieReadiness.test.ts
View file
Open in desktop
File renamed without changes.
0 ...e/src/runtime/adapters/lottieReadiness.ts → packages/core/src/lottieReadiness.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/core/src/runtime/adapters/lottie.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { RuntimeDeterministicAdapter } from "../types";
import { swallow } from "../diagnostics";
export { isLottieAnimationLoaded } from "./lottieReadiness";
export { isLottieAnimationLoaded } from "../../lottieReadiness";

/**
* Lottie adapter for HyperFrames
Expand Down
7 changes: 6 additions & 1 deletion packages/studio/src/components/editor/manualEditingAvailability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ export function resolveStudioBooleanEnvFlag(
return fallback;
}

const env = import.meta.env as StudioFeatureFlagEnv;
// `import.meta.env` is a Vite-only extension. In non-Vite ESM hosts
// (Next.js / Turbopack, Node, jest in some configs) it's undefined,
// and downstream `env[name]` reads would crash. Fall back to `{}` so
// every flag resolves to its declared default outside Vite. Direct
// property access keeps Vite's compile-time transform happy.
const env = (import.meta.env ?? {}) as StudioFeatureFlagEnv;

export const STUDIO_PREVIEW_MANUAL_EDITING_ENABLED = resolveStudioBooleanEnvFlag(
env,
Expand Down
Loading